Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to research generation #10507

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Updates to research generation #10507

merged 1 commit into from
Dec 5, 2024

Conversation

Thodor12
Copy link
Contributor

@Thodor12 Thodor12 commented Dec 5, 2024

Changes proposed in this pull request

  • Changed the generation from item costs lists to simple items (unintentional reuse of functions inside the research provider)
  • Make sure that building requirements have a type
    • This is quick and dirty generation code which has no effect on runtime, I need this to better generate data for the wiki

Testing

  • Yes I tested this before submitting it.
  • I also did a multiplayer test.

Review please

@Thodor12
Mark item costs to actually be a singular item, not an item list, giv…
0d493d4 
…e building requirements explicit types (for the wiki)
@Raycoms Raycoms merged commit 53ccec7 into version/main Dec 5, 2024
5 checks passed
@Raycoms Raycoms deleted the feature/update_requirement_generation branch December 5, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Raycoms Raycoms Raycoms approved these changes

@marchermans marchermans marchermans approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Thodor12 @marchermans @Raycoms