Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reworked AI to pathfinding link: #10543

Merged
merged 3 commits into from
Dec 22, 2024
Merged

Reworked AI to pathfinding link: #10543

merged 3 commits into from
Dec 22, 2024

Conversation

someaddons
Copy link
Contributor

Changes proposed in this pull request

-AI now passes along more information about safe target locations and is using better fitting pathfinding tasks when going to buildings All pathfinding calls now return true on reaching their target, and false while walking unlike being mixed before All logic for creating pathing tasks is now consolidated in a dedicated util: EntityNavigationUtils, slimming down the Navigator class a bit.

Testing

  • [ x] Yes I tested this before submitting it.
  • I also did a multiplayer test.

Review please

AI now passes along more information about safe target locations and is using better fitting pathfinding tasks when going to buildings
All pathfinding calls now return true on reaching their target, and false while walking unlike being mixed before
All logic for creating pathing tasks is now consolidated in a dedicated util: EntityNavigationUtils, slimming down the Navigator class a bit.
Copy link
Contributor

@Raycoms Raycoms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small nitpicks only

Raycoms
Raycoms previously approved these changes Dec 22, 2024
@Raycoms Raycoms merged commit 7c1f25e into version/main Dec 22, 2024
4 checks passed
@Raycoms Raycoms deleted the aipathing branch December 22, 2024 13:00
Raycoms added a commit that referenced this pull request Dec 23, 2024
-AI now passes along more information about safe target locations and is using better fitting pathfinding tasks when going to buildings All pathfinding calls now return true on reaching their target, and false while walking unlike being mixed before All logic for creating pathing tasks is now consolidated in a dedicated util: EntityNavigationUtils, slimming down the Navigator class a bit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants