Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make python-iptables compatible with python 3.12 #351

Merged
merged 2 commits into from
Feb 20, 2025

Conversation

floatingstatic
Copy link
Contributor

@floatingstatic floatingstatic commented Jan 14, 2025

Addresses ModuleNotFound error described in #308 due to https://peps.python.org/pep-0632/
sysconfig was added in python 3.2 but setup in this repo still specifies support for python 2 (and not specific python3 version) so we still first attempt to import distutils and if that fails use sysconfig.

@ldx
Copy link
Owner

ldx commented Feb 19, 2025

Addresses ModuleNotFound error described in #308 due to https://peps.python.org/pep-0632/ sysconfig was added in python 3.2 but setup in this repo still specifies support for python 2 (and not specific python3 version) so we still first attempt to import distutils and if that fails use sysconfig.

This looks great, thank you! Can you rebase on top of current master? I fixed the build recently, so we should be able to merge this after that.

@floatingstatic
Copy link
Contributor Author

@ldx rebased. Let me know if you need anything else! Thanks!

@ldx ldx merged commit 794aace into ldx:master Feb 20, 2025
6 checks passed
@floatingstatic
Copy link
Contributor Author

@ldx any chance we can get a release / version bump pushed up to pypi? Last was v1.0.1 from 2023. With recent changes like this it would be useful to be able to pull from pypi instead of having to pin to a git hash or branch as I'm doing currently

@ldx
Copy link
Owner

ldx commented Feb 24, 2025

@ldx any chance we can get a release / version bump pushed up to pypi? Last was v1.0.1 from 2023. With recent changes like this it would be useful to be able to pull from pypi instead of having to pin to a git hash or branch as I'm doing currently

Absolutely! There are two other fixes waiting to be merged though, so let me take care of those first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants