Enhanced ConcatAsyncOperationExecutor tests to ensure exceptions are …

…thrown correctly
le-nn · Jul 22, 2024 · 8ba5505 · 8ba5505
1 parent 10eb4f5
commit 8ba5505
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 13 deletions.
diff --git a/src/Yolu/Executors/ConcatAsyncOperationExecutor.cs b/src/Yolu/Executors/ConcatAsyncOperationExecutor.cs
@@ -18,7 +18,7 @@ public Task<T> ExecuteAsync<T>(Func<Task<T>> operation) {
         var source = new TaskCompletionSource<T>();
         _operations.Enqueue(new Operation<T>(operation, source));
 
-        Hadle();
+        Handle();
 
         return source.Task;
     }
@@ -35,12 +35,12 @@ public Task ExecuteAsync(Func<Task> operation) {
             return 0;
         }, source));
 
-        Hadle();
+        Handle();
 
         return source.Task;
     }
 
-    private async void Hadle() {
+    private async void Handle() {
         if (_processingCount is not 0) {
             return;
         }
@@ -63,16 +63,13 @@ private interface IOperation {
     }
 
     private readonly struct Operation<T>(Func<Task<T>> func, TaskCompletionSource<T> taskSource) : IOperation {
-        private readonly Func<Task<T>> _func = func;
-        private readonly TaskCompletionSource<T> _taskSource = taskSource;
-
         public async Task HandleAsync() {
             try {
-                var result = await _func.Invoke();
-                _taskSource.SetResult(result);
+                var result = await func.Invoke();
+                taskSource.SetResult(result);
             }
             catch (Exception ex) {
-                _taskSource.SetException(ex);
+                taskSource.SetException(ex);
             }
         }
     }

diff --git a/test/Yolu.Test/Executors/ConcatOperationExecutorTest.cs b/test/Yolu.Test/Executors/ConcatOperationExecutorTest.cs
@@ -164,9 +164,21 @@ public async Task Ensure_OrderOfExecution_With_TaskWhenAll() {
     }
 
     [Fact]
-    public async Task Test2() {
-        foreach (var i in 0..1000) {
-            await Task.Delay(2);
-        }
+    public async Task Ensure_Exception() {
+        var executor = new ConcatAsyncOperationExecutor();
+        var results = new MutableArray<int>();
+
+        await Assert.ThrowsAsync<Exception>(async () => {
+            await executor.ExecuteAsync(() => {
+                throw new Exception("Test");
+            });
+        });
+
+        await Assert.ThrowsAsync<InvalidOperationException>(async () => {
+            await executor.ExecuteAsync(() => {
+                throw new InvalidOperationException("Test");
+            });
+        });
+
     }
 }