Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dev): add watchtower service #27

Closed
wants to merge 1 commit into from
Closed

Conversation

pierreboissinot
Copy link
Member

This service was removed by 2abf6cd

This service was removed by 2abf6cd
@pierreboissinot pierreboissinot self-assigned this May 27, 2024
@aegypius
Copy link
Contributor

aegypius commented May 27, 2024 via email

@pierreboissinot
Copy link
Member Author

This service was removed because of the API call rate-limits of docker hub. Without authentication the rate limit is applied by IP address (and authentication did not work properly) which can be easily reached in an enterprise network.

I do not recommend putting it back as a default.

Le 27 mai 2024 18:04:21 GMT+02:00, Pierre Boissinot @.***> a écrit :

This service was removed by 2abf6cd

You can view, comment on, or merge this pull request online at:

#27

-- Commit Summary --

  • feat(dev): add watchtower service

-- File Changes --

M docker-compose.yml (9)

-- Patch Links --

https://github.com/le-phare/docker-stack/pull/27.patch

https://github.com/le-phare/docker-stack/pull/27.diff

--

Reply to this email directly or view it on GitHub:

#27

You are receiving this because you are subscribed to this thread.

Message ID: @.***>

Ok thx @aegypius

@thislg
Copy link
Member

thislg commented May 29, 2024

Docker Hub rate limits for anonymous users are 100 pulls per 6 hours per IP address which would we problematic even if we configured it to run once a day. With a free account it becomes a non-issue with 200 pulls per 6 hour period per account. So I think we can put an optional Watchtower service in docker-stack: users would need to enable it in their .env file manually. For rate limit issues we could add a part about creating a Docker Hub account in our documentation.

@thislg thislg linked an issue Jun 7, 2024 that may be closed by this pull request
@thislg
Copy link
Member

thislg commented Jul 10, 2024

Closed in favor of #28

@thislg thislg closed this Jul 10, 2024
@thislg thislg deleted the watchtower branch July 10, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add Watchtower to the stack ?
3 participants