Update tile urls of NLS (National Library of Scotland) #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunob
approved these changes
Oct 17, 2023
|
Looks good. It would be nice to have an API key to demonstrate them in our preview: https://leaflet-extras.github.io/leaflet-providers/preview/#filter=NLS @D-Groenewegen do you think we could do that without a cost? Can you also please fix the lint error? |
jieter
changed the title
{variant} not {variants}
Convert double to single quotes.
|
The problem is that we require an API key and with a free account, the maximum number of requests a month is limited. To 1000 API requests if I remember correctly, which is still generous but probably not enough. The only thing I can do is send an email to the National Library of Scotland and ask if we may borrow theirs for the sole purpose of the demo. Using it without permission would be unethical. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #461
Update NLS (National Library of Scotland) because of move to MapTiler Cloud API. For details, see #461.