Allow review from unauthorized users #15
Merged
+34
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukaszgarstecki
requested review from
Saancreed,
pdenert and
michal-kwiatkowski
Test Results3 files 3 suites 16s ⏱️ Results for commit 828be09. ♻️ This comment has been updated with latest results. |
Saancreed
reviewed
Oct 14, 2024
backend/src/LeanCode.AppRating/DataAccess/ModelBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
backend/src/LeanCode.AppRating/DataAccess/ModelBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
lukaszgarstecki
force-pushed
the
feature/allow-review-from-unauthorized-users
branch
from
b6feb42 to
5467faa
Compare
Saancreed
approved these changes
Oct 14, 2024
| @@ -4,5 +4,5 @@ namespace LeanCode.AppRating; | |||
|
|
|||
| public interface IUserIdExtractor<TUserId> | |||
| { | |||
| public TUserId Extract(HttpContext httpContext); | |||
| public bool TryExtract(HttpContext httpContext, out TUserId? userId); | |||
There was a problem hiding this comment.
I would suggest having both, one that throws, and one that doesn't. The one can be implemented (w/ default interface implementation) using the other.
| @@ -1,10 +1,16 @@ | |||
| <Project Sdk="Microsoft.NET.Sdk"> | |||
| <PropertyGroup> | |||
| <EmitCompilerGeneratedFiles>true</EmitCompilerGeneratedFiles> | |||
There was a problem hiding this comment.
I needed that so that I could check the type internals, but I guess we don't need that in repository
jakubfijalkowski
approved these changes
Oct 15, 2024
lukaszgarstecki
deleted the
feature/allow-review-from-unauthorized-users
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a new requirement, that forces us to reconfigure most of the storage part of the rating feature. I'm not sure how we want to approach the data migration to the new backend version (do we care at all?).
Decisions made on the fly:
structs).Tests for unauthorized user are missing...