Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix complete breakage of MacOS automations introduced in #2219 #2233

Merged
merged 2 commits into from
Jun 21, 2024

Conversation

pdenert
Copy link
Collaborator

@pdenert pdenert commented Jun 20, 2024

No description provided.

@pdenert pdenert self-assigned this Jun 20, 2024
@github-actions github-actions bot added docs Concerns doc comments, READMEs, or docs package: patrol Related to the patrol package (native automation, test bundling) labels Jun 20, 2024
@@ -1,3 +1,7 @@
## 3.8.1

- Fix MacOSAutomator
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please let's link some issue and give more info here than just Fix MacOSAutomator so that when we look at it in a year, we know what happened :)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no issue for that. Should I create new one?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can link this PR here. Also we used to write (Unreleased) next to version if it's not released yet

Copy link
Contributor

@mateuszwojtczak mateuszwojtczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add more details to the changelog entry

@mateuszwojtczak
Copy link
Contributor

Maybe let's change the title of this PR and changelog entry to: Fix complete breakage of MacOS automations introduced in #2219

@pdenert pdenert changed the title Fix MacOSAutomator Fix complete breakage of MacOS automations introduced in #2219 Jun 21, 2024
@pdenert pdenert force-pushed the fix/feature-parity branch from d15cdc3 to ff77767 Compare June 21, 2024 10:52
@pdenert pdenert requested a review from mateuszwojtczak June 21, 2024 11:33
Copy link
Contributor

@mateuszwojtczak mateuszwojtczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this situation proves we need to have any minimal tests for macOS 😭

@pdenert pdenert merged commit a8a878a into master Jun 21, 2024
9 of 11 checks passed
@pdenert pdenert deleted the fix/feature-parity branch June 21, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Concerns doc comments, READMEs, or docs package: patrol Related to the patrol package (native automation, test bundling)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants