-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix complete breakage of MacOS automations introduced in #2219 #2233
Conversation
packages/patrol/CHANGELOG.md
Outdated
@@ -1,3 +1,7 @@ | |||
## 3.8.1 | |||
|
|||
- Fix MacOSAutomator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please let's link some issue and give more info here than just Fix MacOSAutomator
so that when we look at it in a year, we know what happened :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's no issue for that. Should I create new one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can link this PR here. Also we used to write (Unreleased) next to version if it's not released yet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add more details to the changelog entry
Maybe let's change the title of this PR and changelog entry to: Fix complete breakage of MacOS automations introduced in #2219 |
d15cdc3
to
ff77767
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, this situation proves we need to have any minimal tests for macOS 😭
No description provided.