Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new notification tile identifier for iOS 18 #2394

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

piotruela
Copy link
Collaborator

Fixes tapping on notification in iOS 18.
Looks like identifier changed in the latest iOS version:
iOS 17:
image
iOS 18:
image

Copy link

docs-page bot commented Nov 5, 2024

To view this pull requests documentation preview, visit the following URL:

docs.page/leancodepl/patrol~2394

Documentation is deployed and generated using docs.page.

@github-actions github-actions bot added the package: patrol Related to the patrol package (native automation, test bundling) label Nov 5, 2024
Copy link
Collaborator

@pdenert pdenert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update changelog and version in pubspec

@piotruela piotruela force-pushed the fix/ios-18-tap-on-notifications branch from e0fc091 to 5f70d84 Compare November 8, 2024 06:31
@piotruela
Copy link
Collaborator Author

Update changelog and version in pubspec

I've updated the changelog, but I didn't bump the version because I plan to release this change together with #2387.

Copy link
Collaborator

@pdenert pdenert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@piotruela piotruela merged commit ced0eac into master Nov 8, 2024
13 of 16 checks passed
@piotruela piotruela deleted the fix/ios-18-tap-on-notifications branch November 8, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: patrol Related to the patrol package (native automation, test bundling)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants