[ICF] Compare alloca position for testing equivalence #173
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an incorrect detection of identical code involving alloca ordering.
Previously for allocas, we only checked if the allocated type, operands and alignment were the same. However this doesn't take into account that two identical alloca instructions at different relative points in the function can not be taken for the same.
Fixed by adding a map that keeps track of allocas that take place at relatively the same position, and using that map to check alloca equivalence.
An example of miscompiled code (compiled with
-O0
):This would generate the following IR before ICF for the functions Foo and Bar:
The instructions:
Would be taken for the same, resulting in a miscompile.