Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debian/ci: merge packages into single binary package #193

Merged
merged 3 commits into from
Jan 23, 2024
Merged

Conversation

Hyxogen
Copy link
Contributor

@Hyxogen Hyxogen commented Jan 19, 2024

Putting this out for review. Please note that the debian package name is currently a placeholder, and that I've also enabled all jobs for this branch which I'll disable once I have a full run that works.

@Hyxogen Hyxogen requested a review from yuri91 January 19, 2024 14:12
@Hyxogen
Copy link
Contributor Author

Hyxogen commented Jan 19, 2024

One thing I did think of as perhaps interesting is to make the RPM package also use the new build script

Copy link
Member

@yuri91 yuri91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
The circleci changes are big and I am not familiar with the original to begin with, so I will just trust you on that.

@yuri91
Copy link
Member

yuri91 commented Jan 19, 2024

One thing I did think of as perhaps interesting is to make the RPM package also use the new build script

@Hyxogen yes please take a look at that. It would be a win to reduce to just one build script

@Hyxogen
Copy link
Contributor Author

Hyxogen commented Jan 19, 2024

One thing I did think of as perhaps interesting is to make the RPM package also use the new build script

@Hyxogen yes please take a look at that. It would be a win to reduce to just one build script

Shall I then also try to merge the RPM packages into one for consistency or leave that like it is now?

@yuri91
Copy link
Member

yuri91 commented Jan 19, 2024

What you find easier. You might have to figure out how to use multiple sources like in debian

@Hyxogen Hyxogen marked this pull request as ready for review January 23, 2024 13:34
@Hyxogen
Copy link
Contributor Author

Hyxogen commented Jan 23, 2024

Requires the cheerp-internal PR to be merged first

@Hyxogen Hyxogen closed this Jan 23, 2024
@Hyxogen Hyxogen reopened this Jan 23, 2024
@Hyxogen Hyxogen requested a review from yuri91 January 23, 2024 13:34
@yuri91 yuri91 merged commit 07edf13 into master Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants