partialexecuter: check for division/remainder by zero #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexp-sssup
reviewed
Feb 13, 2024
| @@ -1727,6 +1727,32 @@ void PartialInterpreter::visitOuter(FunctionData& data, llvm::Instruction& I) | |||
| return; | |||
| } | |||
| } | |||
| if (const BinaryOperator* BO = dyn_cast<BinaryOperator>(&I)) | |||
There was a problem hiding this comment.
I think there is a better place for this logic, there are instruction based checks somewhere else. Cannot check right now, but see for ifs over opcodes or instruction types
Hyxogen
force-pushed
the
fix-pe-div-by-zero
branch
from
a6f3bd5 to
adc25c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: leaningtech/cheerp-meta#139
Fixes: leaningtech/cheerp-meta#140