add CheerpWritePass into TargetMachine of WebAssembly target #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuri91
requested changes
Jun 18, 2024
There was a problem hiding this comment.
This is in the good direction, but let's actually remove CheerpBackend.
Now we have both the previous target and the modified WebAssembly target, but we are not really testing the latter.
We also need to make it so that the WebAssembly target is invoked for the cheerp triplets.
yuri91
force-pushed
the
cheerp_as_subtarget
branch
from
422002a to
c6a1204
Compare
yuri91
force-pushed
the
cheerp_as_subtarget
branch
from
c6430c3 to
1dec8a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
override the addPassesToEmitFile for WebAssembly target to add CheerpWritePass to the queue when it is cheerp target