Fix equal pointers comparison when there is a GEP with more than 2 operands #247
+7
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexp-sssup
reviewed
Aug 15, 2024
| else if ((lhsKind == REGULAR || lhsKind == SPLIT_REGULAR || lhsKind == RAW ||lhsKind == CONSTANT || | ||
| (isGEP(lhs) && (cast<User>(lhs)->getNumOperands()==2 || getGEPContainerType(cast<User>(lhs))->isArrayTy() || getGEPContainerType(cast<User>(lhs))->isPointerTy()))) && | ||
| (rhsKind == REGULAR || rhsKind == SPLIT_REGULAR || rhsKind == RAW ||rhsKind == CONSTANT || | ||
| (isGEP(rhs) && (cast<User>(rhs)->getNumOperands()==2 || getGEPContainerType(cast<User>(rhs))->isArrayTy() || getGEPContainerType(cast<User>(rhs))->isPointerTy())))) |
There was a problem hiding this comment.
I am not sure how the container type could ever be a pointer here. Also, please add a small lambda to check for this condition. The lambda can be used for both operands.
There was a problem hiding this comment.
right, we were thinking about including pointer type assuming that the utility function accepted geps with just one index too, but it does not
rvan-mee
force-pushed
the
fix-pointer-equal-comparison
branch
from
3dd1496 to
c53613b
Compare
rvan-mee
force-pushed
the
fix-pointer-equal-comparison
branch
from
c53613b to
8eb0566
Compare
adds a check to see if the GEP with more then 2 operands is done on an array, if this is the case we can compare the array and its offset directly without dereferencing it
rvan-mee
force-pushed
the
fix-pointer-equal-comparison
branch
from
8eb0566 to
480cdb6
Compare
yuri91
approved these changes
Aug 19, 2024
|
Closing this. for js we will accept undefined as an element. for wasmgc we will add a sentinel value to arrays |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds a check to see if a GEP with more then 2 operands is done on a pointer or an array, if this is the case we can compare the pointer/array and its offset directly without dereferencing the pointers