Fix inconsistent base padding #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When inlining fields of a direct base class, extra padding would sometimes be added to ensure fields in the derived class are at the same offset as they are in the base class, even if one is packed and the other isn't. While this extra padding makes sure that fields end up at the same byte offset, the extra padding fields do shift the index of some fields. The `ComputeNonVirtualBaseClassGepPath` function in `CGClass.cpp` did not properly take into account the possibility these fields having a different index when inlined into a derived class. This is fixed by also adding base classes of the direct base of a derived class into the derived class' `NonVirtualBases` map.
yuri91
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When inlining fields of a direct base class, extra padding would sometimes be added to ensure fields in the derived class are at the same offset as they are in the base class, even if one is packed and the other isn't.
While this extra padding makes sure that fields end up at the same byte offset, the extra padding fields do shift the index of some fields. The
ComputeNonVirtualBaseClassGepPathfunction inCGClass.cppdid not properly take into account the possibility these fields having a different index when inlined into a derived class.This is fixed by also adding base classes of the direct base of a derived class into the derived class'
NonVirtualBasesmap.