Utility thread and further threading support #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuri91
requested changes
Jan 20, 2025
| @@ -1041,6 +1041,7 @@ CheerpWriter::COMPILE_INSTRUCTION_FEEDBACK CheerpWriter::handleBuiltinCall(const | |||
| stream << "import(" << threadingObject << ".script).then(m=>m.default()).catch(e=>{if(e!=='LeakUtilityThread')throw e;});"; | |||
| else | |||
| stream << "importScripts(" << threadingObject << ".script);"; | |||
| stream << "postMessage('hi');"; | |||
There was a problem hiding this comment.
is this needed? do we listen for this message on the other side?
There was a problem hiding this comment.
If required please let's use a more appropriate string. This feel amateurish.
…ility otherwise globals used by the utility thread will be reset on initialization
The size was wrong when booleans were used as thread locals. We now align the thread local area to 8 bytes and calculate the size based on that.
Since there are now 2 places in the code where a new Worker is made, we move the text of the blob into a variable.
This intrinsic will be used in the ThreadLocalLowering pass to bypass a dependency issue with LinearMemoryHelper.
This pass will make it possible to use wasm threadlocals in genericjs, by creating and calling a function in wasm that will calculate the address in memory of the threadlocal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.