-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bound platform movement #39
Conversation
Atm the platform can move out of the canvas. Let's add some bounds! Also if someone wants to tell me why there is fmin and fmax (I thought they were for floats) but not min/max I would gladly add this to the docs too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea bounding movement, and I agree with increasing the speed. We definitely need to explain why we're using fmin
/fmax
over the STL functions.. did std::min
/std::max
not work? Perhaps @yuri91 can provide some insight here
What is the error that is shown if std::min is used? |
Atm I moved on and cannot try with the exact configuration I had before. I tried to add it to my current project and it is working. I amso checked the inputs I was using and they were all ints. I can tell you only that it could not find the function and suggested to use fmin/fmax instead. Since I just wanted to see if it was working, I moved on without recording the error. EDIT: I have found it. I forgot to start with std:: and it suggested me to use fmin instead.
there is also the error for __a obv. |
added the discord explanation in the file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks guys. A small edit then LGTM. Also please run pnpm format
so that CI passes :)
Co-authored-by: Alex Bates <[email protected]>
Atm the platform can move out of the canvas. Let's add some bounds!
Also if someone wants to tell me why there is fmin and fmax (I thought they were for floats) but not min/max I would gladly add this to the docs too
EDIT: I also increased the speed of the platform. I cannot keep up with the ball!