Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(Data/Fintype/List): generalize fintypeNodupList (no DecidableEq) #16656

Closed
wants to merge 13 commits into from

Conversation

mo271
Copy link
Collaborator

@mo271 mo271 commented Sep 10, 2024


Open in Gitpod

@mo271 mo271 added the WIP Work in progress label Sep 10, 2024
Copy link

github-actions bot commented Sep 10, 2024

PR summary 06f5623d10

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ lists_nodup_finset
+ perm_toList

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@mo271 mo271 removed the WIP Work in progress label Sep 10, 2024
@mo271 mo271 marked this pull request as ready for review September 10, 2024 10:23
@mo271
Copy link
Collaborator Author

mo271 commented Sep 10, 2024

Could need some golf, I suppose

Co-authored-by: Violeta Hernández <[email protected]>
@joneugster joneugster added the t-data Data (lists, quotients, numbers, etc) label Sep 12, 2024
@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Oct 27, 2024
@leanprover-community-bot-assistant leanprover-community-bot-assistant removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Nov 12, 2024
Mathlib/Data/Fintype/List.lean Outdated Show resolved Hide resolved
Mathlib/Data/Fintype/List.lean Outdated Show resolved Hide resolved
Mathlib/Data/Fintype/List.lean Outdated Show resolved Hide resolved
@Ruben-VandeVelde Ruben-VandeVelde added the awaiting-author A reviewer has asked the author a question or requested changes label Dec 1, 2024
@mo271 mo271 removed the awaiting-author A reviewer has asked the author a question or requested changes label Dec 1, 2024
@kim-em
Copy link
Contributor

kim-em commented Jan 11, 2025

Could you capitalize Nodup in "The subtype of {l : List α // l.nodup} over a [Fintype α]"?

@kim-em
Copy link
Contributor

kim-em commented Jan 11, 2025

bors d+

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 11, 2025

✌️ mo271 can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@mo271
Copy link
Collaborator Author

mo271 commented Jan 14, 2025

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Jan 14, 2025
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 14, 2025

Build failed:

@mo271
Copy link
Collaborator Author

mo271 commented Jan 14, 2025

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Jan 14, 2025
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 14, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Data/Fintype/List): generalize fintypeNodupList (no DecidableEq) [Merged by Bors] - feat(Data/Fintype/List): generalize fintypeNodupList (no DecidableEq) Jan 14, 2025
@mathlib-bors mathlib-bors bot closed this Jan 14, 2025
@mathlib-bors mathlib-bors bot deleted the mo271/improve_fintypeNodupList branch January 14, 2025 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated t-data Data (lists, quotients, numbers, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants