Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorry-free polynomial FLT #19037

Merged
merged 5 commits into from
Nov 14, 2024
Merged

Sorry-free polynomial FLT #19037

merged 5 commits into from
Nov 14, 2024

Conversation

jcpaik
Copy link
Collaborator

@jcpaik jcpaik commented Nov 14, 2024

Another progress on polynomial FLT #18882


Open in Gitpod

@jcpaik jcpaik requested a review from seewoo5 November 14, 2024 16:03
@github-actions github-actions bot added the new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! label Nov 14, 2024
Copy link

github-actions bot commented Nov 14, 2024

PR summary de6f58a8e9

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.NumberTheory.FLT.Polynomial 1179

Declarations diff

+ Polynomial.flt'
+ Polynomial.flt_catalan
+ Polynomial.flt_catalan_aux
+ fermatLastTheoremPolynomial
+ radical_isUnit_eq
+ radical_isUnit_mul_left
+ radical_isUnit_mul_right
- radical_mul_unit
- radical_unit_eq_one
- radical_unit_mul

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

@jcpaik jcpaik changed the title Feature/poly flt aux Sorry-free polynomial FLT Nov 14, 2024
jcpaik and others added 3 commits November 15, 2024 01:05
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@jcpaik jcpaik added WIP Work in progress and removed new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! labels Nov 14, 2024
@seewoo5 seewoo5 merged commit 4541136 into feature/poly-flt Nov 14, 2024
12 of 14 checks passed
@mathlib-bors mathlib-bors bot deleted the feature/poly-flt-aux branch November 14, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants