Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: constructible sets #20054

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

feat: constructible sets #20054

wants to merge 9 commits into from

Conversation

YaelDillies
Copy link
Collaborator

@YaelDillies YaelDillies commented Dec 19, 2024

Define constructible sets, which are morally sets in a topological space which we can make out of finite unions and intersections of open and closed sets.

From GrowthInGroups (LeanCamCombi)


Open in Gitpod

Copy link

github-actions bot commented Dec 19, 2024

PR summary c2b4440b8d

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.Topology.Constructible (new file) 714

Declarations diff

+ IsConstructible
+ IsConstructible.biInter
+ IsConstructible.biUnion
+ IsConstructible.compl
+ IsConstructible.empty
+ IsConstructible.empty_union_induction
+ IsConstructible.himp
+ IsConstructible.iInter
+ IsConstructible.iUnion
+ IsConstructible.image_of_isClosedEmbedding
+ IsConstructible.image_of_isOpenEmbedding
+ IsConstructible.induction_of_isTopologicalBasis
+ IsConstructible.inter
+ IsConstructible.isLocallyConstructible
+ IsConstructible.of_compl
+ IsConstructible.preimage
+ IsConstructible.preimage_of_isClosedEmbedding
+ IsConstructible.preimage_of_isOpenEmbedding
+ IsConstructible.sInter
+ IsConstructible.sUnion
+ IsConstructible.sdiff
+ IsConstructible.union
+ IsConstructible.univ
+ IsLocallyConstructible
+ IsLocallyConstructible.empty
+ IsLocallyConstructible.finsetInf
+ IsLocallyConstructible.finsetInf'
+ IsLocallyConstructible.iInter
+ IsLocallyConstructible.inter
+ IsLocallyConstructible.sInter
+ IsLocallyConstructible.univ
+ IsRetrocompact
+ IsRetrocompact.biInter
+ IsRetrocompact.biUnion
+ IsRetrocompact.empty
+ IsRetrocompact.finsetInf
+ IsRetrocompact.finsetInf'
+ IsRetrocompact.finsetSup
+ IsRetrocompact.finsetSup'
+ IsRetrocompact.iInter
+ IsRetrocompact.iUnion
+ IsRetrocompact.image_of_isEmbedding
+ IsRetrocompact.inter
+ IsRetrocompact.inter_isOpen
+ IsRetrocompact.isOpen_inter
+ IsRetrocompact.preimage_of_isClosedEmbedding
+ IsRetrocompact.preimage_of_isOpenEmbedding
+ IsRetrocompact.sInter
+ IsRetrocompact.sUnion
+ IsRetrocompact.singleton
+ IsRetrocompact.union
+ IsRetrocompact.univ
+ IsRetrocompact_iff_isSpectralMap_subtypeVal
+ Topology.IsClosedEmbedding.inclusion
+ Topology.IsOpenEmbedding.inclusion
+ _root_.IsRetrocompact.isCompact
+ _root_.IsRetrocompact.isConstructible
+ _root_.IsRetrocompact.isLocallyConstructible
+ _root_.TopologicalSpace.IsTopologicalBasis.isConstructible
+ _root_.TopologicalSpace.IsTopologicalBasis.isConstructible'
+ _root_.TopologicalSpace.IsTopologicalBasis.isRetrocompact
+ _root_.TopologicalSpace.IsTopologicalBasis.isRetrocompact'
+ _root_.TopologicalSpace.IsTopologicalBasis.isRetrocompact_iff_isCompact
+ _root_.TopologicalSpace.IsTopologicalBasis.isRetrocompact_iff_isCompact'
+ isConstructible_compl
+ isConstructible_preimage_of_isOpenEmbedding

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-topology Topological spaces, uniform spaces, metric spaces, filters label Dec 19, 2024
@YaelDillies YaelDillies requested a review from b-mehta December 19, 2024 09:17
@AntoineChambert-Loir AntoineChambert-Loir added the awaiting-author A reviewer has asked the author a question or requested changes label Dec 20, 2024
@YaelDillies YaelDillies removed the awaiting-author A reviewer has asked the author a question or requested changes label Dec 21, 2024
@jcommelin jcommelin requested a review from erdOne December 23, 2024 10:54
Mathlib/Topology/Constructible.lean Outdated Show resolved Hide resolved
Mathlib/Topology/Constructible.lean Outdated Show resolved Hide resolved
Mathlib/Topology/Constructible.lean Outdated Show resolved Hide resolved
Mathlib/Topology/Constructible.lean Outdated Show resolved Hide resolved
YaelDillies and others added 9 commits January 7, 2025 10:56
Define constructible sets, which are morally sets in a topological space which we can
make out of unions and intersections of open and closed sets.

From GrowthInGroups (LeanCamCombi)
Co-authored-by: Junyan Xu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-topology Topological spaces, uniform spaces, metric spaces, filters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants