Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore: use app_delab #20249

Closed
wants to merge 1 commit into from
Closed

Conversation

eric-wieser
Copy link
Member

@eric-wieser eric-wieser commented Dec 26, 2024

This has the same behavior as delab app., but protects against typos.

The feature appeared in leanprover/lean4#4976, though won't be documented until leanprover/lean4#6450.


Open in Gitpod

This has the same behavior as `delab app.`, but protects against typos.
@eric-wieser eric-wieser added easy < 20s of review time. See the lifecycle page for guidelines. t-meta Tactics, attributes or user commands labels Dec 26, 2024
Copy link

PR summary 1337be9707

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Copy link
Contributor

@bryangingechen bryangingechen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
bors r+

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the ready-to-merge This PR has been sent to bors. label Dec 28, 2024
mathlib-bors bot pushed a commit that referenced this pull request Dec 28, 2024
This has the same behavior as `delab app.`, but protects against typos.

The feature appeared in leanprover/lean4#4976, though won't be documented until leanprover/lean4#6450.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Dec 28, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: use app_delab [Merged by Bors] - chore: use app_delab Dec 28, 2024
@mathlib-bors mathlib-bors bot closed this Dec 28, 2024
@mathlib-bors mathlib-bors bot deleted the app_delab branch December 28, 2024 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors. t-meta Tactics, attributes or user commands
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants