Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Algebra): add missing substructure lemmas #20269

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

artie2000
Copy link
Collaborator

@artie2000 artie2000 commented Dec 27, 2024

Add missing boilerplate lemmas about the maps .toNonUnitalSubsemiring and .subsemiringClosure

This PR is split off from #16094


Open in Gitpod

@github-actions github-actions bot added the new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! label Dec 27, 2024
Copy link

github-actions bot commented Dec 27, 2024

PR summary 8193df3116

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ Submonoid.subsemiringClosure_toNonUnitalSubsemiring
+ Subsemiring.coe_toNonUnitalSubsemiring
+ Subsemiring.mem_toNonUnitalSubsemiring
+ Subsemiring.toNonUnitalSubsemiring_eq
+ Subsemiring.toNonUnitalSubsemiring_injective
+ subsemiringClosure_mem

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-algebra Algebra (groups, rings, fields, etc) label Dec 27, 2024
@artie2000 artie2000 changed the title feat(Algebra/Algebra/Subalgebra/Unitisation): add missing toNonUnitalSubsemiring lemmas feat(Algebra): add missing substructure lemmas Dec 27, 2024
Copy link
Collaborator

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

maintainer delegate

show (S₁.toNonUnitalSubsemiring : Set R) = S₂ from SetLike.ext'_iff.1 h)

@[simp]
theorem Subsemiring.toNonUnitalSubsemiring_eq {S₁ S₂ : Subsemiring R} :
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
theorem Subsemiring.toNonUnitalSubsemiring_eq {S₁ S₂ : Subsemiring R} :
theorem Subsemiring.toNonUnitalSubsemiring_inj {S₁ S₂ : Subsemiring R} :

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

named by analogy to e.g. Subgroup.toSubmonoid_eq

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, many precedents exist for both conventions
is there consensus on which is preferred?

Copy link

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer-merge new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! t-algebra Algebra (groups, rings, fields, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants