-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Algebra): add missing substructure lemmas #20269
base: master
Are you sure you want to change the base?
Conversation
PR summary 8193df3116Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
maintainer delegate
show (S₁.toNonUnitalSubsemiring : Set R) = S₂ from SetLike.ext'_iff.1 h) | ||
|
||
@[simp] | ||
theorem Subsemiring.toNonUnitalSubsemiring_eq {S₁ S₂ : Subsemiring R} : |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
theorem Subsemiring.toNonUnitalSubsemiring_eq {S₁ S₂ : Subsemiring R} : | |
theorem Subsemiring.toNonUnitalSubsemiring_inj {S₁ S₂ : Subsemiring R} : |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
named by analogy to e.g. Subgroup.toSubmonoid_eq
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, many precedents exist for both conventions
is there consensus on which is preferred?
🚀 Pull request has been placed on the maintainer queue by YaelDillies. |
Add missing boilerplate lemmas about the maps
.toNonUnitalSubsemiring
and.subsemiringClosure
This PR is split off from #16094