Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: constructible sets in the prime spectrum #20274

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

YaelDillies
Copy link
Collaborator

Provide tooling for manipulating constructible sets in the prime spectrum of a ring.

From GrowthInGroups (LeanCamCombi)

Co-authored-by: Andrew Yang


Open in Gitpod

Provide tooling for manipulating constructible sets in the prime spectrum of a ring.

From GrowthInGroups (LeanCamCombi)

Co-authored-by: Andrew Yang
Copy link

PR summary e80bbd46c4

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.AlgebraicGeometry.PrimeSpectrum.ConstructibleSet (new file) 1468

Declarations diff

+ ConstructibleSetData
+ degBound
+ map
+ map_comp
+ map_id
+ reduce
+ toSet
+ toSet_map
+ toSet_reduce

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-algebraic-geometry Algebraic geometry label Dec 27, 2024
Comment on lines +46 to +49
open scoped Classical in
/-- Remove the zero polynomials from the data of a constructible set. -/
noncomputable def reduce (S : ConstructibleSetData R) : ConstructibleSetData R :=
S.image fun ⟨_, r, f⟩ ↦ ⟨#{x | f x ≠ 0}, r, f ∘ Subtype.val ∘ (Finset.equivFin _).symm⟩
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-algebraic-geometry Algebraic geometry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants