Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add codeaction and widget to succes_if_fail_with_msg tactic #20378

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

edegeltje
Copy link
Collaborator

@edegeltje edegeltje commented Jan 1, 2025

make the success_if_fail_with_msg tactic give a codeaction when the tactics given fail with a different error, to update the expected error message.

example:

example : Nat → Nat → True := by
  success_if_fail_with_msg "no goals" -- Update with tactic error message: "no goals to be solved"
    intro
    intro
    trivial
    trivial
  intros; trivial

Open in Gitpod

@edegeltje edegeltje added the t-meta Tactics, attributes or user commands label Jan 1, 2025
@github-actions github-actions bot added the large-import Automatically added label for PRs with a significant increase in transitive imports label Jan 1, 2025
Copy link

github-actions bot commented Jan 1, 2025

PR summary 2c2995bcc2

Import changes exceeding 2%

% File
+5.00% Mathlib.Tactic.SuccessIfFailWithMsg

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.Tactic.SuccessIfFailWithMsg 20 21 +1 (+5.00%)
Import changes for all files
Files Import difference
Mathlib.Tactic.SuccessIfFailWithMsg 1

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@kim-em
Copy link
Contributor

kim-em commented Jan 4, 2025

Please add the example from the PR description as a new test.

@kim-em kim-em added the awaiting-author A reviewer has asked the author a question or requested changes label Jan 4, 2025
@kim-em
Copy link
Contributor

kim-em commented Jan 4, 2025

The large-import label is fine to ignore for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-author A reviewer has asked the author a question or requested changes large-import Automatically added label for PRs with a significant increase in transitive imports t-meta Tactics, attributes or user commands
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants