-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(Topology/Algebra/Module/ModuleTopology): finite products of modules. #20453
Conversation
…les have the module topology.
PR summary c99e6bc6c8Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diff
You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit> The doc-module for No changes to technical debt.You can run this locally as
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks! Just a bunch of nitpicks.
I might add that I think it's a bit crazy that we have to write proofs like the instPi
one here manually. I wonder who could write a tactic for this?
bors d+
✌️ kbuzzard can now approve this pull request. To approve and merge a pull request, simply reply with |
Co-authored-by: Oliver Nash <[email protected]>
Co-authored-by: Oliver Nash <[email protected]>
bors merge |
…les. (#20453) From FLT. Binary and finite products of modules with the module topology also have the module topology.
Pull request successfully merged into master. Build succeeded: |
From FLT. Binary and finite products of modules with the module topology also have the module topology.