Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(Topology/Algebra/Module/ModuleTopology): finite products of modules. #20453

Closed
wants to merge 9 commits into from

Conversation

kbuzzard
Copy link
Member

@kbuzzard kbuzzard commented Jan 3, 2025

From FLT. Binary and finite products of modules with the module topology also have the module topology.


Open in Gitpod

@kbuzzard kbuzzard added t-topology Topological spaces, uniform spaces, metric spaces, filters t-algebra Algebra (groups, rings, fields, etc) labels Jan 3, 2025
Copy link

github-actions bot commented Jan 3, 2025

PR summary c99e6bc6c8

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ instPi
+ instProd

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Copy link
Contributor

@ocfnash ocfnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks! Just a bunch of nitpicks.

I might add that I think it's a bit crazy that we have to write proofs like the instPi one here manually. I wonder who could write a tactic for this?

bors d+

Mathlib/Topology/Algebra/Module/ModuleTopology.lean Outdated Show resolved Hide resolved
Mathlib/Topology/Algebra/Module/ModuleTopology.lean Outdated Show resolved Hide resolved
Mathlib/Topology/Algebra/Module/ModuleTopology.lean Outdated Show resolved Hide resolved
Mathlib/Topology/Algebra/Module/ModuleTopology.lean Outdated Show resolved Hide resolved
Mathlib/Topology/Algebra/Module/ModuleTopology.lean Outdated Show resolved Hide resolved
Mathlib/Topology/Algebra/Module/ModuleTopology.lean Outdated Show resolved Hide resolved
Mathlib/Topology/Algebra/Module/ModuleTopology.lean Outdated Show resolved Hide resolved
Mathlib/Topology/Algebra/Module/ModuleTopology.lean Outdated Show resolved Hide resolved
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 12, 2025

✌️ kbuzzard can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ocfnash
Copy link
Contributor

ocfnash commented Jan 12, 2025

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the ready-to-merge This PR has been sent to bors. label Jan 12, 2025
mathlib-bors bot pushed a commit that referenced this pull request Jan 12, 2025
…les. (#20453)

From FLT. Binary and finite products of modules with the module topology also have the module topology.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 12, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Topology/Algebra/Module/ModuleTopology): finite products of modules. [Merged by Bors] - feat(Topology/Algebra/Module/ModuleTopology): finite products of modules. Jan 12, 2025
@mathlib-bors mathlib-bors bot closed this Jan 12, 2025
@mathlib-bors mathlib-bors bot deleted the kbuzzard-module-topology-prod-and-pi branch January 12, 2025 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc) t-topology Topological spaces, uniform spaces, metric spaces, filters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants