Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Mathlib/Data): setOf_eq_singleton_iff_of_nodup #20488

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

LeoDog896
Copy link
Collaborator

@LeoDog896 LeoDog896 commented Jan 5, 2025

Adds setOf_eq_singleton_iff_of_nodup with the generalizing setOf_nodup_perm.


Open in Gitpod

@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jan 5, 2025
@LeoDog896 LeoDog896 force-pushed the tristanfr.setOf_singleton_iff_nodup branch from dca136c to d219efb Compare January 5, 2025 06:57
Copy link

github-actions bot commented Jan 5, 2025

PR summary 2c1b10e739

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ List.setOf_fintype
+ setOf_eq_singleton_iff_of_nodup
+ setOf_inj
+ setOf_mem_empty
+ setOf_mem_eq_empty_iff
+ setOf_nodup_perm

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@leanprover-community-bot-assistant leanprover-community-bot-assistant removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jan 5, 2025
@LeoDog896 LeoDog896 added the t-data Data (lists, quotients, numbers, etc) label Jan 5, 2025
Mathlib/Data/Set/Basic.lean Outdated Show resolved Hide resolved
Mathlib/Data/List/Lemmas.lean Outdated Show resolved Hide resolved
Mathlib/Data/List/Lemmas.lean Outdated Show resolved Hide resolved
Mathlib/Data/List/Nodup.lean Outdated Show resolved Hide resolved
@LeoDog896 LeoDog896 changed the title feat(Mathlib/Data): setOf_singleton_iff_nodup feat(Mathlib/Data): setOf_eq_singleton_iff_of_nodup Jan 5, 2025
@LeoDog896
Copy link
Collaborator Author

LeoDog896 commented Jan 6, 2025

Note that setOf_mem_empty, setOf_mem_eq_empty_iff, and setOf_inj are no longer used in this PR. They still seem like useful lemmas to keep, but I can split them to a separate PR / delete them if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-data Data (lists, quotients, numbers, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants