Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Computability/ContextFreeGrammar): no need to open Function #21456

Closed
wants to merge 1 commit into from

Conversation

madvorak
Copy link
Collaborator

@madvorak madvorak commented Feb 5, 2025


Open in Gitpod

@madvorak madvorak added the easy < 20s of review time. See the lifecycle page for guidelines. label Feb 5, 2025
Copy link

github-actions bot commented Feb 5, 2025

PR summary 2b13bc7ad4

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

++-- reverse_bijective
++-- reverse_injective
++-- reverse_involutive
++-- reverse_surjective

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-computability Computability theory (TMs, DFAs, languages, grammars, etc) label Feb 5, 2025
@grunweg
Copy link
Collaborator

grunweg commented Feb 5, 2025

Personally, I'm on the fence about this change. I won't object to it, but I won't approve it as "this is obviously better, we should do it" either.

@madvorak
Copy link
Collaborator Author

madvorak commented Feb 7, 2025

Let's do it after the bigger refactoring.

@madvorak madvorak closed this Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy < 20s of review time. See the lifecycle page for guidelines. t-computability Computability theory (TMs, DFAs, languages, grammars, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants