fix: filter out term sorries that come from tactic sorries #68
+33
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tactic sorry now has a child `exact sorry` in the infotree
kim-em
merged commit 1e282b9
into
leanprover-community:bump_to_v4.16.0-rc2
2 checks passed
kim-em
added a commit
that referenced
this pull request
Jan 15, 2025
* chore: bump to v4.16.0-rc2 * fix * fix: filter out term sorries that come from tactic sorries (#68) * fix: filter out term sorries that come from tactic sorries tactic sorry now has a child `exact sorry` in the infotree * bump test * fix mathlib test --------- Co-authored-by: L <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as of leanprover/lean4#5757, the tactic macro
sorrynow expands toexact sorryinstead ofexact @sorryAx _ falseso we need to avoid double counting thesorry.In addition,
sorryis now using thismkLabeledSorrywhich adds a number of constants tousedConstants.