feat: make MapDeclarationExtension tolerate multiple insertions
#5911
+13
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplifies the definition of `MapDeclarationExtension` so that it only contains a `NameMap` without an additional `List (Name × α)`. Uses the `NameMap`'s natural ordering during export rather than sorting. This fixes issues from inserting into a `MapDeclarationExtension` multiple times with the same key. Inside a module it appears that each insertion overwrites the data, since those queries access the `NameMap`. But across modules, only the first insertion is accessible, since each insertion was actually pushed to the front of a `List`. Mathlib needs this for a documentation extension feature, and [they are considering a PR with a workaround](leanprover-community/mathlib4#17043) that digs into the `MapDeclarationExtension` data structures.
github-actions
bot
added
the
toolchain-available
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Nov 1, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Nov 1, 2024
leanprover-community-bot
added
the
builds-mathlib
|
Mathlib CI status (docs):
|
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Nov 1, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Nov 1, 2024
leodemoura
approved these changes
Nov 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifies the definition of
MapDeclarationExtensionso that it only contains aNameMapwithout an additionalList (Name × α). Uses theNameMap's natural ordering during export rather than sorting.This fixes issues from inserting into a
MapDeclarationExtensionmultiple times with the same key. Inside a module it appears that each insertion overwrites the data, since those queries access theNameMap. But across modules, only the first insertion is accessible, since each insertion was actually pushed to the front of aList.Mathlib needs this for a documentation extension feature, and they are considering a PR with a workaround that digs into the
MapDeclarationExtensiondata structures.