feat: add text option for buildFile* utilities
#5924
+119
−70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tydeu
changed the title
text option for buildFile* utilitiestext option for buildFile* utilities
github-actions
bot
added
the
toolchain-available
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Nov 2, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Nov 2, 2024
|
Mathlib CI status (docs):
|
tydeu
force-pushed
the
lake/build-text-file
branch
from
566d1eb
to
de68bb4
Compare
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Nov 2, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Nov 2, 2024
leanprover-community-bot
added
the
builds-mathlib
tydeu
force-pushed
the
lake/build-text-file
branch
2 times, most recently
from
9514a75
to
1b5454e
Compare
tydeu
force-pushed
the
lake/build-text-file
branch
from
1b5454e
to
6db54c2
Compare
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Nov 2, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Nov 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an optional
textargument to thefetchFile*andbuildFile*definitions that can be used to hash built files as text files (with normalized line endings) instead of as binary files (the previous default).Separately, this change also significantly expands the documentation in the
Lake.Build.Tracemodule and preforms minor touchups of some build job signatures.