Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add noStop option to EasySpeech.speak in EasySpeech.js #271

Merged
merged 4 commits into from
Apr 25, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/EasySpeech.js
Original file line number Diff line number Diff line change
Expand Up @@ -684,7 +684,7 @@
* @fulfill {SpeechSynthesisEvent} Resolves to the `end` event
* @reject {SpeechSynthesisEvent} rejects using the `error` event
*/
EasySpeech.speak = ({ text, voice, pitch, rate, volume, force, infiniteResume, ...handlers }) => {
EasySpeech.speak = ({ text, voice, pitch, rate, volume, force, infiniteResume, noStop, ...handlers }) => {
ensureInit({ force })

if (!validate.text(text)) {
Expand Down Expand Up @@ -809,7 +809,11 @@

// make sure we have no mem-leak
clearTimeout(timeoutResumeInfinity)
internal.speechSynthesis.cancel()

//do not cancel currently playing voice, if noStop option is true explicitly.

Check failure on line 813 in src/EasySpeech.js

View workflow job for this annotation

GitHub Actions / unit tests (16)

Expected space or tab after '//' in comment

Check failure on line 813 in src/EasySpeech.js

View workflow job for this annotation

GitHub Actions / unit tests (18)

Expected space or tab after '//' in comment

Check failure on line 813 in src/EasySpeech.js

View workflow job for this annotation

GitHub Actions / unit tests (20)

Expected space or tab after '//' in comment
if (!(noStop === true)) {
internal.speechSynthesis.cancel();

Check failure on line 815 in src/EasySpeech.js

View workflow job for this annotation

GitHub Actions / unit tests (16)

Extra semicolon

Check failure on line 815 in src/EasySpeech.js

View workflow job for this annotation

GitHub Actions / unit tests (18)

Extra semicolon

Check failure on line 815 in src/EasySpeech.js

View workflow job for this annotation

GitHub Actions / unit tests (20)

Extra semicolon
}

setTimeout(() => internal.speechSynthesis.speak(utterance), 10)
})
Expand Down
Loading