Refactory dynamic chunking to plugin #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 15, 2023
|
🎉 This seems to work! Ill see if one of the dataflow jobs runs successfully and then we can finish this part of the hack up tomorrow @cisaacstern |
This was referenced Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring the CMIP6 recipe to make use of the new
dynamic_chunking_fnoption toStoreToZarr(pangeo-forge/pangeo-forge-recipes#595).This required moving out the logic built in pangeo-forge/pangeo-forge-recipes#546 into a new package dynamic_chunks. I ended up separating some of the 'retry with different algos' out of there and moved it to the recipe here.