Update shentu bech32 prefix to shentu #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @baryon2 could you check this PR? I know that Shentu is not a major chain but the change is minor. Thanks! |
Dan0025046789
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shentu prefix was updated in version 2.8.0, see https://github.com/shentufoundation/shentu/releases/
Version 2.8.0 changes the Bech32 address prefix to 'shentu'.Using the certik prefix causes issues with rest endpoints, for example
https://shentu-rest.publicnode.com/cosmos/staking/v1beta1/delegations/certik1npauvhjz4zm4pejsquh3ey3lh3ec207k7p978e?pagination.limit=1000Updating
bech32PrefixAccAddrshould be sufficient as the value is passed topackages/snap/src/wallet/wallet.ts#createmethod inaddressPrefixwhich will generate the correct public address.