Skip to content

Conversation

goblincore
Copy link
Collaborator

@goblincore goblincore commented Aug 25, 2025

Overview

🎟 Relevant Jira Issues

https://welibrary.atlassian.net/browse/LC-914

📚 What is the context and goal of this PR?

Adds new fields such that the requested data can be added to the boost

Add the following fields:

(HIGH) World Scouting Region (single-select dropdown)

Options: Africa, Arab, Asia-Pacific, Europe, Global, Interamerica, Other

(MED) Country (single-select dropdown)

Values are provided via an external source (on this link). This list must be Manually editable via the backend.

HIGH) Network Type (single-select dropdown)

Options: NSO/NSA, Event, Other

🥴 TL; RL:

Adds new fields such that the requested data can be added to the boost

💡 Feature Breakdown (screenshots & videos encouraged!)

New field of new type BoostNetworkFields

export type BoostNetworkFields = {
    networkType?: string;
    country?: string;
    region?: string;
    organization?: string;
};

//add network field to BoostTemplate
export type BoostTemplate = {

    network?: BoostNetworkFields;
 
};

update contexts:

"network": {
                    "@id": "lcn:boostNetwork",
                    "@context": {
                        "networkType": {
                            "@id": "lcn:boostNetworkType",
                            "@type": "xsd:string"
                        },
                        "country": {
                            "@id": "lcn:boostNetworkCountry",
                            "@type": "xsd:string"
                        },
                        "region": {
                            "@id": "lcn:boostNetworkRegion",
                            "@type": "xsd:string"
                        },
                        "organization": {
                            "@id": "lcn:boostNetworkOrganization",
                            "@type": "xsd:string"
                        }
                    }
                },


🛠 Important tradeoffs made:

🔍 Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Chore (refactor, documentation update, etc)

💳 Does This Create Any New Technical Debt? ( If yes, please describe and add JIRA TODOs )

  • No
  • Yes

Testing

🔬 How Can Someone QA This?

📱 🖥 Which devices would you like help testing on?

🧪 Code Coverage

Documentation

📜 Gitbook

📊 Storybook

✅ PR Checklist

  • Related to a Jira issue (create one if not)
  • My code follows style guidelines (eslint / prettier)
  • I have manually tested common end-2-end cases
  • I have reviewed my code
  • I have commented my code, particularly where ambiguous
  • New and existing unit tests pass locally with my changes
  • I have made corresponding changes to gitbook documentation

🚀 Ready to squash-and-merge?:

  • Code is backwards compatible
  • There is not a "Do Not Merge" label on this PR
  • I have thoughtfully considered the security implications of this change.
  • This change does not expose new public facing endpoints that do not have authentication

✨ PR Description

Purpose: Add network field types to the boost credential model and update context definitions to support network information.

Main changes:

  • Added BoostNetworkFields type with networkType, country, region, and organization fields
  • Updated VC templates to include network field in boost credentials
  • Added network context definitions in new JSON-LD context file version 1.0.2

Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using. We'd love your feedback! 🚀

Copy link

changeset-bot bot commented Aug 25, 2025

🦋 Changeset detected

Latest commit: 1a8241e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 14 packages
Name Type
@learncard/vc-templates-plugin Patch
@learncard/init Patch
@learncard/network-brain-service Patch
@learncard/learn-cloud-service Patch
@learncard/chapi-example Patch
@learncard/create-http-bridge Patch
@learncard/cli Patch
@learncard/react Patch
learn-card-discord-bot Patch
@learncard/network-brain-client Patch
@learncard/learn-cloud-client Patch
@learncard/learn-cloud-plugin Patch
@learncard/snap-chapi-example Patch
@learncard/network-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Aug 25, 2025

Deploy Preview for learncarddocs canceled.

Name Link
🔨 Latest commit 1a8241e
🔍 Latest deploy log https://app.netlify.com/projects/learncarddocs/deploys/68acfd97a0e2b40008216f2a

Copy link
Contributor

@gitstream-cm gitstream-cm bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨ PR Review

The PR implements the network field functionality as described, adding proper TypeScript types and JSON-LD context definitions. The implementation follows existing codebase patterns and maintains backwards compatibility.

1 issues detected:

🎯 Scope - Implementation includes a field not specified in the project requirements

Details: The BoostNetworkFields type includes an 'organization' field that is not mentioned in the Jira ticket requirements. The ticket specifies only World Scouting Region, Country, and Network Type fields.
File: packages/plugins/vc-templates/src/types.ts (81-81)

Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using. We'd love your feedback! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant