-
Notifications
You must be signed in to change notification settings - Fork 9
[LC-914] Add network field types and update context definitions #798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 1a8241e The changes in this PR will be included in the next version bump. This PR includes changesets to release 14 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for learncarddocs canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨ PR Review
The PR implements the network field functionality as described, adding proper TypeScript types and JSON-LD context definitions. The implementation follows existing codebase patterns and maintains backwards compatibility.
1 issues detected:
🎯 Scope - Implementation includes a field not specified in the project requirements
Details: The BoostNetworkFields type includes an 'organization' field that is not mentioned in the Jira ticket requirements. The ticket specifies only World Scouting Region, Country, and Network Type fields.
File:packages/plugins/vc-templates/src/types.ts (81-81)
Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using. We'd love your feedback! 🚀
Overview
🎟 Relevant Jira Issues
https://welibrary.atlassian.net/browse/LC-914
📚 What is the context and goal of this PR?
Adds new fields such that the requested data can be added to the boost
Add the following fields:
(HIGH) World Scouting Region (single-select dropdown)
Options: Africa, Arab, Asia-Pacific, Europe, Global, Interamerica, Other
(MED) Country (single-select dropdown)
Values are provided via an external source (on this link). This list must be Manually editable via the backend.
HIGH) Network Type (single-select dropdown)
Options: NSO/NSA, Event, Other
🥴 TL; RL:
Adds new fields such that the requested data can be added to the boost
💡 Feature Breakdown (screenshots & videos encouraged!)
New field of new type BoostNetworkFields
update contexts:
🛠 Important tradeoffs made:
🔍 Types of Changes
💳 Does This Create Any New Technical Debt? ( If yes, please describe and add JIRA TODOs )
Testing
🔬 How Can Someone QA This?
📱 🖥 Which devices would you like help testing on?
🧪 Code Coverage
Documentation
📜 Gitbook
📊 Storybook
✅ PR Checklist
🚀 Ready to squash-and-merge?:
✨ PR Description
Purpose: Add network field types to the boost credential model and update context definitions to support network information.
Main changes:
Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using. We'd love your feedback! 🚀