fix: LC-1365 - Update verification expiration response

[gerardopar]

Overview

🎟 Relevant Jira Issues

LC-1365

PART OF THIS PR

📚 What is the context and goal of this PR?

Issue: User reported that the expiration verification messages were confusing.

This PR simplifies the API response copy for credential expiration:

1. Expiration: Valid - Does not Expire → Expiration: Does not Expire
2. Expiration: Valid - Does not Expire → Expiration: Expires {data}
3. Expiration: Expires {date} → Expiration: Expires {date}
4. Expiration: Invalid - Expired → Expiration: Expired

This makes the verification results clearer and more consistent.

🥴 TL; RL:

💡 Feature Breakdown (screenshots & videos encouraged!)

🛠 Important tradeoffs made:

🔍 Types of Changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Chore (refactor, documentation update, etc)

💳 Does This Create Any New Technical Debt? ( If yes, please describe and add JIRA TODOs )

• No
• Yes

Testing

🔬 How Can Someone QA This?

Confirm the verification expiration copy has been simplified

📱 🖥 Which devices would you like help testing on?

🧪 Code Coverage

Documentation

📜 Gitbook

📊 Storybook

✅ PR Checklist

• Related to a Jira issue (create one if not)
• My code follows style guidelines (eslint / prettier)
• I have manually tested common end-2-end cases
• I have reviewed my code
• I have commented my code, particularly where ambiguous
• New and existing unit tests pass locally with my changes
• I have made corresponding changes to gitbook documentation

🚀 Ready to squash-and-merge?:

• Code is backwards compatible
• There is not a "Do Not Merge" label on this PR
• I have thoughtfully considered the security implications of this change.
• This change does not expose new public facing endpoints that do not have authentication

✨ PR Description

Purpose: Update verification expiration message format by removing "Valid •" and "Invalid •" prefixes for improved readability.
Main changes:

• Simplified credential expiration messages in transformErrorMessage and transformCheckMessage functions
• Updated test helpers to match new message format without validity prefixes
• Added changeset file to trigger patch version updates for affected packages

Generated by LinearB AI and added by gitStream.
_{AI-generated content may contain inaccuracies. Please verify before using. We'd love your feedback! 🚀}

[changeset-bot]

🦋 Changeset detected

Latest commit: 4756635

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 17 packages

Name	Type
@learncard/react	Patch
@learncard/learn-card-plugin	Patch
@learncard/chapi-example	Patch
@learncard/snap-chapi-example	Patch
@learncard/init	Patch
@learncard/network-brain-service	Patch
@learncard/learn-cloud-service	Patch
@learncard/simple-signing-service	Patch
@learncard/create-http-bridge	Patch
@learncard/cli	Patch
learn-card-discord-bot	Patch
@learncard/network-brain-client	Patch
@learncard/learn-cloud-client	Patch
@learncard/learn-cloud-plugin	Patch
@learncard/simple-signing-client	Patch
@learncard/network-plugin	Patch
@learncard/simple-signing-plugin	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[netlify]

✅ Deploy Preview for learncarddocs canceled.

Name	Link
🔨 Latest commit	4756635
🔍 Latest deploy log	https://app.netlify.com/projects/learncarddocs/deploys/68dffce64b2e3b00082e15be

[gitstream-cm]

✨ PR Review

The PR successfully simplifies verification expiration messages by removing redundant prefixes like "Valid •" and "Invalid •", making the messages cleaner and more concise. However, there's a significant mismatch between the ticket description and the implemented changes.

1 issues detected:

🎯 Scope - The implemented changes don't align with the ticket's reported issue about badge claiming and visual glitches.

Details: The PR description and changes focus on simplifying expiration verification messages, but the linked ticket (LC-1365) describes an entirely different issue about "claiming badge from link displays strange page with visual glitch" and badge claiming functionality, not verification message formatting.
File: packages/plugins/learn-card/src/verify.ts (16-17)

Generated by LinearB AI and added by gitStream.
_{AI-generated content may contain inaccuracies. Please verify before using. We'd love your feedback! 🚀}

[gitstream-cm]

🎯 Scope - Scope Mismatch: Verify that the correct ticket is referenced, or ensure the PR addresses the actual ticket requirements about badge claiming visual glitches rather than verification message formatting.

Suggested change

	? `Expired ${format(new Date(credential.expirationDate), 'dd MMM yyyy').toUpperCase()}`
	: 'Expired';
	? `Credential expired on ${format(new Date(credential.expirationDate), 'dd MMM yyyy')}`
	: 'Credential has expired';

[gitstream-cm]

🥷 Code experts: TaylorBeeston, smurflo2

TaylorBeeston, smurflo2 have most 👩‍💻 activity in the files.
smurflo2, TaylorBeeston have most 🧠 knowledge in the files.

See details

packages/plugins/learn-card/src/verify.ts

Activity based on git-commit:

	TaylorBeeston	smurflo2
OCT
SEP
AUG
JUL
JUN
MAY

Knowledge based on git-blame:
TaylorBeeston: 100%

packages/react-learn-card/src/components/VCDisplayCard/VCDisplayCard.stories.tsx

Activity based on git-commit:

	TaylorBeeston	smurflo2
OCT
SEP
AUG
JUL
JUN	27 additions & 0 deletions
MAY

Knowledge based on git-blame:
TaylorBeeston: 41%

packages/react-learn-card/src/helpers/test.helpers.ts

Activity based on git-commit:

	TaylorBeeston	smurflo2
OCT
SEP
AUG
JUL		4 additions & 4 deletions
JUN	62 additions & 0 deletions	100 additions & 1 deletions
MAY

Knowledge based on git-blame:
smurflo2: 91%
TaylorBeeston: 9%

✨ Comment /gs review for LinearB AI review. Learn how to automate it here.

[gitstream-cm]

✨ PR Review

The PR implements clean message simplification for credential expiration responses, removing verbose prefixes to improve user experience. However, there appears to be a significant mismatch between the ticket requirements and the actual implementation.

1 issues detected:

🎯 Scope - The PR implementation does not match the linked ticket requirements

Details: The linked ticket LC-1365 describes a bug about claiming badges showing "Unknown Issuer" and visual glitches, but this PR implements changes to verification expiration message text. The implementation does not address the ticket requirements at all.
File: packages/plugins/learn-card/src/verify.ts

Generated by LinearB AI and added by gitStream.
_{AI-generated content may contain inaccuracies. Please verify before using. We'd love your feedback! 🚀}