Add multi-language support to Windows installer #183
+80
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Externalizes user-facing strings from `kolibri.iss` into separate `.isl` language files under the `Installer_Languages/` directory. This change restores multi-language functionality from the legacy installer and enables a language selection dialog at startup. Initial support for English and German is included.
Dimi20cen
force-pushed
the
feat/windows/inno_setup_localization
branch
from
12267e8 to
c22e54e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR restores multi-language support to the Windows installer, addressing a regression from our legacy version. All user-facing strings have been moved from
kolibri.issinto.isllanguage files.Changes
Installer_Languages/directory with initial files for English and German.kolibri.issto use language keys and enabled the startup language selection dialog.References
Fixes #181, partially
Reviewer guidance
How to test on Windows:
make dependencies).make pyinstallerto build the application.make build-installer-windows(requires Inno Setup installed)dist-installer/kolibri-setup-0.18.1.exe