-
Notifications
You must be signed in to change notification settings - Fork 636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to sections in ExamPage #12182
Changes from 4 commits
bb48d8e
9681689
e989aa6
cc9fe58
599460b
e296ed5
8401422
d9bee6b
6c900c9
2198598
8366ee9
239d377
0140393
5b7ef32
02e0bb0
7c0b654
766faf0
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -140,6 +140,7 @@ | |
@submit="handleOpenQuiz(activeQuiz.id)" | ||
> | ||
<p>{{ openQuizModalDetail$() }}</p> | ||
<p>{{ canNoLongerEditQuizNotice$() }}</p> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This should be conditionalized on |
||
<p | ||
v-if=" | ||
activeQuiz.data_model_version === 3 && | ||
|
@@ -240,6 +241,7 @@ | |
newQuizAction$, | ||
filterQuizStatus$, | ||
quizClosedLabel$, | ||
canNoLongerEditQuizNotice$, | ||
} = coachStrings; | ||
|
||
const statusSelected = ref({ | ||
|
@@ -275,6 +277,7 @@ | |
titleLabel$, | ||
recipientsLabel$, | ||
sizeLabel$, | ||
canNoLongerEditQuizNotice$, | ||
statusLabel$, | ||
newQuizAction$, | ||
filterQuizStatus$, | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -73,7 +73,7 @@ export const enhancedQuizManagementStrings = createTranslator('EnhancedQuizManag | |
message: 'Add questions', | ||
}, | ||
selectFoldersOrExercises: { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Might be worth changing the message id if we're not only allowing selection of resources? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. +1 good thought richard |
||
message: 'Select folders or exercises from these channels', | ||
message: 'Select resources from these channels', | ||
}, | ||
numberOfSelectedBookmarks: { | ||
message: '{ count, number } { count, plural, one { bookmark } other { bookmarks }}', | ||
|
@@ -102,6 +102,9 @@ export const enhancedQuizManagementStrings = createTranslator('EnhancedQuizManag | |
replaceAction: { | ||
message: 'Replace', | ||
}, | ||
replaceQuestionsHeading: { | ||
message: 'The new questions you select will replace the current ones.', | ||
}, | ||
replaceQuestionsExplaination: { | ||
message: 'The new questions you selected will replace the current ones.', | ||
}, | ||
|
@@ -220,8 +223,7 @@ export const enhancedQuizManagementStrings = createTranslator('EnhancedQuizManag | |
context: 'Message of modal when a user tries to replace questions but the pool is empty', | ||
}, | ||
addMoreResourcesWithNonEmptyPool: { | ||
message: | ||
'Please add more resources to this section, or go back and only select up to { available, number } { available, plural, one { question } other { questions } } to be replaced.', | ||
message: 'Please add more resources to this section, or go back and select fewer questions', | ||
context: | ||
'Message of modal when a user tries to replace more questions than are available in the pool', | ||
}, | ||
|
@@ -241,6 +243,10 @@ export const enhancedQuizManagementStrings = createTranslator('EnhancedQuizManag | |
saveAndClose: { | ||
message: 'Save and close', | ||
}, | ||
questionDeletionConfirmation: { | ||
message: | ||
'Are you sure you want to remove { count, number } { count, plural, one { question } other { questions }} from this section?', | ||
}, | ||
}); | ||
|
||
const { sectionLabel$ } = enhancedQuizManagementStrings; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is inaccurate - it should be something like "You will no longer be able to edit the questions and sections in this quiz" - as they will still be able to edit the title and assignments.