EQM Fix: Use can actually select topics #12265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
APP: Coach
nucleogenesis
commented
Jun 11, 2024
| actuallyHasCheckbox(content) { | ||
| return content.kind === ContentNodeKinds.EXERCISE | ||
| ? this.hasCheckbox(content) && this.unusedQuestionsCount(content) > 0 | ||
| : this.hasCheckbox(content); |
There was a problem hiding this comment.
Note that we're assuming here that the API is the thing that matches our given string where we say a folder can only have <=12 resources in it and no sub-folders.
I'm thinking we maybe should be enforcing that on the client-side in order to be sure we will always match our string
There was a problem hiding this comment.
hasCheckbox is saying a topic cannot have a checkbox if there is a more property on the response -- that is where the assumption is made against the API in useQuizResources
Build Artifacts
|
|
Hi @nucleogenesis, cool stuff, just noticed the following issues:
2024-06-13_15-54-02.mp4
|
rtibbles
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes issue following up from #12182 where users could not select entire topics under certain conditions.
Reviewer guidance
When a Topic / Folder has no folders within it AND there are 12 or fewer exercises in it, then the topic should have a checkbox.
Otherwise, topics should not have checkboxes.
Also -- if a particular exercise has been added to another section and all of its questions have been used in another section, then that Exercise should not have checkbox.