-
Notifications
You must be signed in to change notification settings - Fork 636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EQM Fix: Use can actually select topics #12265
EQM Fix: Use can actually select topics #12265
Conversation
actuallyHasCheckbox(content) { | ||
return content.kind === ContentNodeKinds.EXERCISE | ||
? this.hasCheckbox(content) && this.unusedQuestionsCount(content) > 0 | ||
: this.hasCheckbox(content); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that we're assuming here that the API is the thing that matches our given string where we say a folder can only have <=12 resources in it and no sub-folders.
I'm thinking we maybe should be enforcing that on the client-side in order to be sure we will always match our string
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hasCheckbox
is saying a topic cannot have a checkbox if there is a more
property on the response -- that is where the assumption is made against the API in useQuizResources
Build Artifacts
|
Hi @nucleogenesis, cool stuff, just noticed the following issues:
2024-06-13_15-54-02.mp4
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This allows folders to be selected, we have moved the remaining changes needed to follow up issues.
Summary
Fixes issue following up from #12182 where users could not select entire topics under certain conditions.
Reviewer guidance
When a Topic / Folder has no folders within it AND there are 12 or fewer exercises in it, then the topic should have a checkbox.
Otherwise, topics should not have checkboxes.
Also -- if a particular exercise has been added to another section and all of its questions have been used in another section, then that Exercise should not have checkbox.