Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Remove legacy stuff from conf.py #12563

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

benjaoming
Copy link
Contributor

I didn't notice this while I was fixing the jquery issue... but it originated from having this legacy setup.

The reason that sphinxcontrib.jquery is added to extentions is because the html_theme_path definition (from old old instructions) disables some other things that the theme adds (like jquery).

Can wait for the docs to build, and it should probably still work 👍

The reason that sphinxcontrib.jquery is added to extentions is because the `html_theme_path` definition (from old old instructions) disables some other things that the theme adds (like jquery)
@github-actions github-actions bot added the DEV: backend Python, databases, networking, filesystem... label Aug 14, 2024
@benjaoming
Copy link
Contributor Author

Yup, the docs build still works 👍

Copy link
Member

@jredrejo jredrejo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Ben!

@jredrejo jredrejo merged commit 9e95c49 into learningequality:develop Aug 15, 2024
40 checks passed
@benjaoming benjaoming deleted the docs-minimal-pinning branch August 15, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DEV: backend Python, databases, networking, filesystem...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants