Gracefully handle failure of ifcfg due to multiple IP bindings. #5914
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When an interface has multiple IPs bound to it, the following issue surfaces: ftao/python-ifcfg#34
This prevents Kolibri from starting at all.
After this PR, this situation is handled somewhat gracefully:
Reviewer guidance
Wasn't able to force a replication locally, but tested the fix on the remote server where the issue was being observed, and it worked.
References
Sidesteps issue caused by ftao/python-ifcfg#34
Contributor Checklist
PR process:
Testing:
Reviewer Checklist
yarn
andpip
)