[Remove Vuetify from Studio] Collection name input and validation in Channels - New collection #5382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll look into the failing workflow 👍 |
|
Hi @AadarshM07, thank you! Yes please have a look at failing tests. We will assign a reviewer soon. |
MisRob
changed the title
AadarshM07
force-pushed
the
issue#5298
branch
from
4093579 to
23458e0
Compare
|
I updated the tests to replace |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removed Vuetify from the collection name input on the
Channels > New Collection page, and updated the validation logic togenerateFormMixin.Verified that the text box still supports the following features:
Screenshots:
…
References
Closes #5298
…
Reviewer guidance
In the previous Vuetify textbox behavior, the "Field is required" message appeared when submitting without input and disappeared once the textbox was focused again.
In the current
KTextbox, the error message does not disappear on focus after being triggered.I checked the KTextbox documentation and couldn’t find any prop that controls this behavior - if this is not the right approach, suggestions would be helpful.
…