-
Notifications
You must be signed in to change notification settings - Fork 231
[Remove Vuetify from Studio] Deactivate and delete confirmation dialogs in admin user actions #5426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: unstable
Are you sure you want to change the base?
Conversation
Thank you @Prashant-thakur77, we will assign a reviewer next week. |
Hi @rtibbles @AlexVelezLl will update the pr as soon as changes in the below given pr gets merged as they are related to the issue faced here.learningequality/kolibri-design-system#1138 this is the concerned pr. ;) |
68bfdd5
to
00673ad
Compare
Hi @AlexVelezLl , I've implemented the changes. Please review when you have time and let me know if there are any further adjustments needed. I'm happy to make any improvements you suggest. |
Hi @Prashant-thakur77, I think we need to wait until we install the new KDS release with your update since you need it here too, right? |
Yes @MisRob |
Okay, we will coordinate with you :) Then let the reviewers know after that's done, please - it's best to review after all is set up. We couldn't merge it anyway any time sooner. Thank you |
Hi @Prashant-thakur77, we've just installed to Studio's |
…test file to handle KModal
ebcfc67
to
5e86660
Compare
@AlexVelezLl @MisRob i have Rebased the pr to the latest and checked the working locally.Do tell if any changes are needed :) |
Fixes #5411
Summary
Migrated 2 user action confirmation dialogs from Vuetify to KDS KModal.
After images for Desktop users:
After images for Mobile users:
References
• Parent issue: #5060
Reviewer guidance
Login as [email protected] with password a
Go to Administration > Users
Click Actions dropdown in the last column of the table
Click Deactivate
Click Delete