-
Notifications
You must be signed in to change notification settings - Fork 231
[Remove Vuetify from Studio] Add / remove admin privileges dialogs #5469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: unstable
Are you sure you want to change the base?
[Remove Vuetify from Studio] Add / remove admin privileges dialogs #5469
Conversation
this.dialog = false; | ||
}) | ||
.catch(() => { | ||
this.showSnackbar({ text: this.$tr('ErrorMessage') }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just quickly from the code I don't think that snackbar was displayed before or was it? Please double-check, and if that's the case, remove this logic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, actually I was referring to changeUserPassword.vue so added it. Will remove
Thank you @rishabhjain1712, we will assign a reviewer next week. Meanwhile see my note on user experience, and also I noticed that tests check is failing - needs to be fixed. |
@MisRob hey i have removed the snackbar and also all the test cases are passing on local |
@marcellamaki if you make a new pr let me know what changes you make, so i can learn. this is my first contribution so a lot to learn |
@rishabhjain1712 Marcella won't make a new PR - her assignment means that she will review your pull request :) |
Fixes #5441
Summary
This PR refactors the User Privilege Modal to remove dependency on Vuetify (
v-dialog
,v-form
, etc.) and migrate it to use Kolibri Design System (KDS) components such asKModal
,KTextbox
, andKButton
.v-dialog
withKModal
for modal rendering.v-form
in favor ofgenerateFormMixin
for validation handling.Add/Remove privilege
,Cancel
) to work with KDS event handling (@submit
,@cancel
).confirmAction
,close
,onSubmit
) and state management remain functional.Manual Verification
Opened the User Privilege Modal in the Admin > Users section.
Verified that:
generateFormMixin
.Screenshots:
(Already included above 👆)
References
Related issue: Refactor Vuetify usage in user privilege modal to KDS equivalents ([Remove Vuetify from Studio] Add / remove admin privileges dialogs #5441 )([Remove Vuetify from Studio] Add / remove admin privileges dialogs #5441)
Internal discussion: Migration to KDS components and removal of Vuetify dependencies
Component references:
kolibri-design-system
v5.2.2vue
v2.7.16Reviewer Guidance
To test these changes:
Navigate to the User Management section in the app.
Open a user’s privilege modal.
Verify:
Ensure no UI regressions or console errors occur.