fix: close ledger sheet in request keys flow

[alter-eggo]

Try out Leather build efce52d — Extension build, Test report, Storybook, Chromatic

Fixed broken close ledger connect sheet
Task: https://linear.app/leather-io/issue/LEA-2078/fix-ledger-cancel-navigation

[kyranjamie]

You can't remove the handler and default to navigating home, that'll break flows in which the user isn't mean to visit home page, e.g. all the RPC flows

[kyranjamie]

The routes for the ledger flows are such that /stacks/ or /bitcoin by themselves are not valid. What other ways can we ensure users do land on those routes?

[alter-eggo]

@kyranjamie @pete-watters guys could you review/test please

[pete-watters]

@kyranjamie @pete-watters guys could you review/test please

The code looks OK and I will test now but can you please link a ticket to the PR and add it in the commit message?

Otherwise it's not clear what the goal of this PR is

[pete-watters]

I did some testing here and it doesn't reintroduce this bug anymore so that's good.

I did hit an issue when cancelling a transaction though. If I:

• Sign into Gamma with Ledger
• try and buy some ordinal
• cancel signing

It crashes with :

TypeError: Cannot read properties of null (reading 'inputsLength')
    at getPsbtTxInputs (chrome-extension://dbbkfepagfalpohacffnpaodaklhamif/index.js:273885:31)
    at ApproveSignLedgerBitcoinTx (chrome-extension://dbbkfepagfalpohacffnpaodaklhamif/index.js:115547:80)
    at renderWithHooks (chrome-extension://

bug_cancelling.mp4

The transaction stays open on the Ledger too. I double checked and that doesn't happen on dev but I could be wrong.

It's been a while since I checked this though and I can't remember what issue its fixing so if you can link that it would be great.

[alter-eggo]

@pete-watters I checked and on dev this error happens for me too.
ledger connect success state closing is quite buggy in all the flows, since after showing it we navigate user to the signing page, for example here

I feel like we need to make this state uncancellable, wdyt?

[pete-watters]

@pete-watters I checked and on dev this error happens for me too. ledger connect success state closing is quite buggy in all the flows, since after showing it we navigate user to the signing page, for example here

I feel like we need to make this state uncancellable, wdyt?

Good idea! Maybe it is supposed to be non-cancellable there but became broken?

[kyranjamie]

If the action is cancelled, why do we return anything at all with the action? Do we need this?

[alter-eggo]

we need for abort handler

    function signingAbortedHandler(msg: GlobalAppEvents['ledgerBitcoinTxSigningCancelled']) {
      if (msg.unsignedPsbt === psbt) {
        appEvents.unsubscribe('ledgerBitcoinTxSigningCancelled', signingAbortedHandler);
        appEvents.unsubscribe('ledgerBitcoinTxSigned', txSignedHandler);
        reject(new Error('User cancelled the signing operation'));
      }
    }