fix: show available metadata for stacks nfts #6090
Open
+28
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyranjamie
reviewed
Jan 29, 2025
| <ImageUnavailable /> | ||
| </CollectibleItemLayout> | ||
| ); | ||
| const isImageAvailable = src && isValidUrl(src); |
There was a problem hiding this comment.
If the issue is that src is undefined, we have a mismatch between runtime and our types
There was a problem hiding this comment.
It comes back as undefined for video / audio NFT's only. Maybe I need to add a new type for those NFTs?
We can't play them anyway as the token_uri is not giving us a valid video file.
This change basically keeps the code as it was before but displays the metadata we do have rather than a larger Image not found card:
There was a problem hiding this comment.
zod schema checking here would be great too, but so long as the types align with the runtime I'm happy
kyranjamie
approved these changes
Jan 29, 2025
alter-eggo
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an improvement to show the available metadata we have for Stacks NFTs so users can see their names in the wallet