Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: stx_signMessage #6101

Merged
merged 1 commit into from
Feb 7, 2025
Merged

test: stx_signMessage #6101

merged 1 commit into from
Feb 7, 2025
+2,319 −1,324

Conversation

kyranjamie
Copy link
Collaborator

@kyranjamie kyranjamie commented Feb 7, 2025 •
edited by leather-bot
Loading

Try out Leather build 4bf30dc — Extension build, Test report, Storybook, Chromatic

In preparation for adding new APIs and introducing changes to existing ones, I've added some tests as we're missing them for stx_signMessage

@kyranjamie kyranjamie force-pushed the test/stx-message-signing branch 2 times, most recently from d344439 to 5ad59a3 Compare February 7, 2025 14:21
@kyranjamie kyranjamie marked this pull request as ready for review February 7, 2025 14:21
@kyranjamie kyranjamie requested a review from fbwoolf February 7, 2025 14:22
fbwoolf
fbwoolf approved these changes Feb 7, 2025
View reviewed changes
Copy link
Contributor

@fbwoolf fbwoolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realized during testing all of our deployed contracts for the test-app are missing. I think they were wiped with the Stacks testnet updates, so we will have to redeploy some test contracts at some point.

@kyranjamie kyranjamie force-pushed the test/stx-message-signing branch 3 times, most recently from 1f7a1c4 to 2f15187 Compare February 7, 2025 15:50
@kyranjamie kyranjamie force-pushed the test/stx-message-signing branch from 2f15187 to 4bf30dc Compare February 7, 2025 16:39
@kyranjamie kyranjamie merged commit ae32c37 into dev Feb 7, 2025
32 checks passed
@kyranjamie kyranjamie deleted the test/stx-message-signing branch February 7, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbwoolf fbwoolf fbwoolf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kyranjamie @fbwoolf