Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change extend window calculations #146

Merged
merged 2 commits into from
Jul 5, 2023
Merged

Change extend window calculations #146

merged 2 commits into from
Jul 5, 2023

Conversation

friedger
Copy link
Collaborator

@friedger friedger commented Jul 5, 2023

This PR

@vercel
Copy link

vercel bot commented Jul 5, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
stacking ✅ Ready (Inspect) Visit Preview Jul 5, 2023 8:16am

@friedger friedger requested a review from kyranjamie July 5, 2023 08:14
kyranjamie
kyranjamie approved these changes Jul 5, 2023
View reviewed changes
src/constants.ts
icon: `${window.location.origin}/logo.svg`,
};
export const APP_DETAILS =
typeof window !== 'undefined'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why wouldn't window be defined?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because it is run in vitest.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we do it differently @kyranjamie Let's discuss in #145

@friedger friedger added this pull request to the merge queue Jul 5, 2023
Merged via the queue into main with commit f25c5a4 Jul 5, 2023
@friedger friedger deleted the fix/extend-window-144 branch July 5, 2023 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyranjamie kyranjamie kyranjamie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extend button disabled while showing "Extend in -54 blocks"
2 participants
@friedger @kyranjamie