feat(data-studio): add max length to attributes

Co-authored-by: Renaud Amsellem <[email protected]> test(data-studio): replace mock function
leav-solutions · Mar 4, 2024 · 18048ba · 18048ba
1 parent 5722efe
commit 18048ba
Show file tree

Hide file tree

Showing 10 changed files with 2,139 additions and 5,666 deletions.
diff --git a/apps/admin/src/_gqlTypes/globalTypes.ts b/apps/admin/src/_gqlTypes/globalTypes.ts
@@ -267,6 +267,7 @@ export interface AttributeInput {
     values_list?: ValuesListConfInput | null;
     reverse_link?: string | null;
     unique?: boolean | null;
+    maxLength?: number | null;
 }
 
 export interface DeleteTaskInput {

diff --git a/apps/core/src/app/core/attributeApp/attributeApp.ts b/apps/core/src/app/core/attributeApp/attributeApp.ts
@@ -48,7 +48,7 @@ interface IDeps {
     'core.utils'?: IUtils;
 }
 
-export default function (deps: IDeps = {}): ICoreAttributeApp {
+export default function(deps: IDeps = {}): ICoreAttributeApp {
     const {
         'core.domain.attribute': attributeDomain = null,
         'core.domain.record': recordDomain = null,
@@ -185,7 +185,8 @@ export default function (deps: IDeps = {}): ICoreAttributeApp {
                         ${attributesInterfaceSchema}
                         embedded_fields: [EmbeddedAttribute],
                         values_list: StandardValuesListConf,
-                        unique: Boolean
+                        unique: Boolean,
+                        maxLength: Int
                     }
 
                     type LinkAttribute implements Attribute{
@@ -218,7 +219,8 @@ export default function (deps: IDeps = {}): ICoreAttributeApp {
                         metadata_fields: [String!],
                         values_list: ValuesListConfInput,
                         reverse_link: String,
-                        unique: Boolean
+                        unique: Boolean,
+                        maxLength: Int
                     }
 
                     type EmbeddedAttribute {
@@ -393,21 +395,23 @@ export default function (deps: IDeps = {}): ICoreAttributeApp {
                             // TODO: this could be optimized if find() would allow searching for multiple IDs at once
                             return {
                                 ...attributeData.values_list,
-                                values: (attributeData.values_list.values as string[]) || []
-                                    .map(async recId => {
-                                        const record = await recordDomain.find({
-                                            params: {
-                                                library: attributeData.linked_library,
-                                                filters: [
-                                                    {field: 'id', condition: AttributeCondition.EQUAL, value: recId}
-                                                ]
-                                            },
-                                            ctx
-                                        });
-
-                                        return record.list.length ? record.list[0] : null;
-                                    })
-                                    .filter(r => r !== null) // Remove invalid values (unknown records)
+                                values:
+                                    (attributeData.values_list.values as string[]) ||
+                                    []
+                                        .map(async recId => {
+                                            const record = await recordDomain.find({
+                                                params: {
+                                                    library: attributeData.linked_library,
+                                                    filters: [
+                                                        {field: 'id', condition: AttributeCondition.EQUAL, value: recId}
+                                                    ]
+                                                },
+                                                ctx
+                                            });
+
+                                            return record.list.length ? record.list[0] : null;
+                                        })
+                                        .filter(r => r !== null) // Remove invalid values (unknown records)
                             };
                         }
                     },

diff --git a/libs/ui/src/__mocks__/common/attribute.ts b/libs/ui/src/__mocks__/common/attribute.ts
@@ -47,6 +47,7 @@ export const mockAttributeWithDetails: AttributeDetailsFragment = {
         fr: 'Ma description',
         en: 'My description'
     },
+    maxLength: null,
     unique: false,
     readonly: false,
     multiple_values: false