feat(core/ui): refresh auto computed fields (#669)

leav-solutions · Dec 20, 2024 · f569c5e · f569c5e
1 parent eab60f2
commit f569c5e
Show file tree

Hide file tree

Showing 37 changed files with 279 additions and 26 deletions.
diff --git a/apps/core/src/__tests__/mocks/actionsList.ts b/apps/core/src/__tests__/mocks/actionsList.ts
@@ -8,6 +8,7 @@ const mockActionBase: IActionsListFunction = {
     id: 'myAction',
     name: 'MyAction',
     description: 'My action',
+    compute: false,
     input_types: Object.values(ActionsListIOTypes),
     output_types: Object.values(ActionsListIOTypes),
     action: jest.fn()

diff --git a/apps/core/src/_types/actionsList.ts b/apps/core/src/_types/actionsList.ts
@@ -70,6 +70,7 @@ export interface IActionsListFunction<
     output_types: ActionsListIOTypes[];
     params?: Array<ActionsListParamsConfig<ParamsRequired>>;
     error_message?: ISystemTranslation;
+    compute: boolean;
     action: (
         values: IValue[],
         params: PartialByCondition<ActionsListParams<keyof ParamsRequired>, ParamsRequired>,

diff --git a/apps/core/src/app/core/attributeApp/attributeApp.ts b/apps/core/src/app/core/attributeApp/attributeApp.ts
@@ -70,6 +70,7 @@ export default function (deps: IDeps): ICoreAttributeApp {
             coreApp.filterSysTranslationField(attributeData.description, args.lang || []),
         input_types: (attributeData, _, ctx) => attributeDomain.getInputTypes({attrData: attributeData, ctx}),
         output_types: (attributeData, _, ctx) => attributeDomain.getOutputTypes({attrData: attributeData, ctx}),
+        compute: (attributeData, _, ctx) => attributeDomain.doesCompute(attributeData),
         metadata_fields: async (attributeData: IAttribute, _, ctx) =>
             !!attributeData.metadata_fields
                 ? Promise.all(
@@ -138,6 +139,7 @@ export default function (deps: IDeps): ICoreAttributeApp {
                 output_types: ActionListIOTypes!,
                 metadata_fields: [StandardAttribute!],
                 libraries: [Library!],
+                compute: Boolean!,
 
                 # Permissions for this attribute.
                 # If record is specified, returns permissions for this specific record, otherwise returns global attribute permissions
@@ -195,14 +197,14 @@ export default function (deps: IDeps): ICoreAttributeApp {
                         maxLength: Int
                     }
 
-                    type LinkAttribute implements Attribute{
+                    type LinkAttribute implements Attribute {
                         ${attributesInterfaceSchema}
                         linked_library: Library,
                         values_list: LinkValuesListConf,
                         reverse_link: String
                     }
 
-                    type TreeAttribute implements Attribute{
+                    type TreeAttribute implements Attribute {
                         ${attributesInterfaceSchema}
                         linked_tree: Tree,
                         values_list: TreeValuesListConf

diff --git a/apps/core/src/domain/actions/dateRangeToNumberAction.ts b/apps/core/src/domain/actions/dateRangeToNumberAction.ts
@@ -11,6 +11,7 @@ export default function (): IActionsListFunction {
         description: 'Convert date range dates to numbers',
         input_types: [ActionsListIOTypes.OBJECT],
         output_types: [ActionsListIOTypes.OBJECT],
+        compute: false,
         action: values => ({
             values: values.map(valueElement => {
                 const dateRangeValue = valueElement.payload as IDateRangeValue<string>;

diff --git a/apps/core/src/domain/actions/encryptAction.ts b/apps/core/src/domain/actions/encryptAction.ts
@@ -12,6 +12,7 @@ export default function (): IActionsListFunction {
         description: 'Encrypt value',
         input_types: [ActionsListIOTypes.STRING],
         output_types: [ActionsListIOTypes.STRING],
+        compute: false,
         action: async values =>
             values.reduce(
                 async (promAcc, valueElement) => {

diff --git a/apps/core/src/domain/actions/excelCalculationAction.ts b/apps/core/src/domain/actions/excelCalculationAction.ts
@@ -74,6 +74,7 @@ export default function ({
         description: 'Performs an excel calculation',
         input_types: [ActionsListIOTypes.STRING, ActionsListIOTypes.NUMBER],
         output_types: [ActionsListIOTypes.STRING],
+        compute: true,
         params: [
             {
                 name: 'Description',

diff --git a/apps/core/src/domain/actions/formatDateAction.ts b/apps/core/src/domain/actions/formatDateAction.ts
@@ -21,6 +21,7 @@ export default function (): IActionsListFunction<{localized: false; universal: f
         description: 'Convert timestamp to a date',
         input_types: [ActionsListIOTypes.NUMBER],
         output_types: [ActionsListIOTypes.STRING],
+        compute: false,
         params: [
             {
                 name: 'localized',

diff --git a/apps/core/src/domain/actions/formatDateRangeAction.ts b/apps/core/src/domain/actions/formatDateRangeAction.ts
@@ -22,6 +22,7 @@ export default function (): IActionsListFunction<{localized: false; universal: f
         description: 'Convert range timestamps to a range dates',
         input_types: [ActionsListIOTypes.OBJECT],
         output_types: [ActionsListIOTypes.OBJECT],
+        compute: false,
         params: [
             {
                 name: 'localized',

diff --git a/apps/core/src/domain/actions/formatNumberAction.ts b/apps/core/src/domain/actions/formatNumberAction.ts
@@ -31,6 +31,7 @@ export default function (): IActionsListFunction<{
         description: 'Format a number',
         input_types: [ActionsListIOTypes.NUMBER],
         output_types: [ActionsListIOTypes.STRING],
+        compute: false,
         params: [
             {
                 name: 'decimals',

diff --git a/apps/core/src/domain/actions/inheritanceCalculationAction.ts b/apps/core/src/domain/actions/inheritanceCalculationAction.ts
@@ -31,6 +31,7 @@ export default function ({
             ActionsListIOTypes.OBJECT,
             ActionsListIOTypes.BOOLEAN
         ],
+        compute: true,
         params: [
             {
                 name: 'Description',

diff --git a/apps/core/src/domain/actions/maskValueAction.ts b/apps/core/src/domain/actions/maskValueAction.ts
@@ -10,6 +10,7 @@ export default function (): IActionsListFunction {
         description: 'Mask any value by replacing with dots or empty string if no value',
         input_types: [ActionsListIOTypes.STRING, ActionsListIOTypes.NUMBER, ActionsListIOTypes.OBJECT],
         output_types: [ActionsListIOTypes.STRING],
+        compute: false,
         action: values => {
             const _isValueDefined = value =>
                 value !== null && value !== '' && (typeof value !== 'object' || Object.keys(value).length);

diff --git a/apps/core/src/domain/actions/parseJSONAction.ts b/apps/core/src/domain/actions/parseJSONAction.ts
@@ -10,6 +10,7 @@ export default function (): IActionsListFunction {
         description: 'Parse a JSON string',
         input_types: [ActionsListIOTypes.STRING],
         output_types: [ActionsListIOTypes.OBJECT],
+        compute: false,
         action: values => {
             const computedValues = values.map(elementValue => {
                 elementValue.payload = JSON.parse('' + elementValue.payload);

diff --git a/apps/core/src/domain/actions/toBooleanAction.ts b/apps/core/src/domain/actions/toBooleanAction.ts
@@ -10,6 +10,7 @@ export default function (): IActionsListFunction {
         description: 'Convert value to boolean',
         input_types: [ActionsListIOTypes.STRING, ActionsListIOTypes.NUMBER, ActionsListIOTypes.BOOLEAN],
         output_types: [ActionsListIOTypes.BOOLEAN],
+        compute: false,
         action: values => {
             const computedValues = values.map(elementValue => {
                 switch (elementValue.payload) {

diff --git a/apps/core/src/domain/actions/toJSONAction.ts b/apps/core/src/domain/actions/toJSONAction.ts
@@ -10,6 +10,7 @@ export default function (): IActionsListFunction {
         description: 'Convert value to a JSON string',
         input_types: [ActionsListIOTypes.OBJECT],
         output_types: [ActionsListIOTypes.STRING],
+        compute: false,
         action: values => {
             const computedValues = values.map(elementValue => {
                 elementValue.payload = elementValue?.payload === null ? null : JSON.stringify(elementValue.payload);

diff --git a/apps/core/src/domain/actions/toNumberAction.ts b/apps/core/src/domain/actions/toNumberAction.ts
@@ -10,6 +10,7 @@ export default function (): IActionsListFunction {
         description: 'Convert value to number',
         input_types: [ActionsListIOTypes.STRING, ActionsListIOTypes.NUMBER, ActionsListIOTypes.BOOLEAN],
         output_types: [ActionsListIOTypes.NUMBER],
+        compute: false,
         action: values => {
             const computedValues = values.map(elementValue => {
                 elementValue.payload = elementValue.payload !== null ? Number(elementValue.payload) : null;

diff --git a/apps/core/src/domain/actions/toStringAction.ts b/apps/core/src/domain/actions/toStringAction.ts
@@ -10,6 +10,7 @@ export default function (): IActionsListFunction {
         description: 'Convert value to string',
         input_types: [ActionsListIOTypes.STRING, ActionsListIOTypes.NUMBER, ActionsListIOTypes.BOOLEAN],
         output_types: [ActionsListIOTypes.STRING],
+        compute: false,
         action: values => {
             const computedValues = values.map(elementValue => {
                 elementValue.payload = elementValue.payload !== null ? String(elementValue.payload) : null;

diff --git a/apps/core/src/domain/actions/toUppercaseAction.ts b/apps/core/src/domain/actions/toUppercaseAction.ts
@@ -10,6 +10,7 @@ export default function (): IActionsListFunction {
         description: 'Convert the string to uppercase',
         input_types: [ActionsListIOTypes.STRING],
         output_types: [ActionsListIOTypes.STRING],
+        compute: false,
         action: values => {
             const computedValues = values.map(elementValue => {
                 elementValue.payload =

diff --git a/apps/core/src/domain/actions/validateEmailAction.ts b/apps/core/src/domain/actions/validateEmailAction.ts
@@ -13,6 +13,7 @@ export default function (): IActionsListFunction {
         description: 'Check if value is a string matching email format',
         input_types: [ActionsListIOTypes.STRING],
         output_types: [ActionsListIOTypes.STRING],
+        compute: false,
         action: values => {
             const allErrors = values.reduce((errors, elementValue) => {
                 if (!elementValue.payload.match(EMAIL_REGEX)) {

diff --git a/apps/core/src/domain/actions/validateFormatAction.ts b/apps/core/src/domain/actions/validateFormatAction.ts
@@ -13,6 +13,7 @@ export default function (): IActionsListFunction {
         id: 'validateFormat',
         name: 'Validate Format',
         description: 'Check if value matches attribute format',
+        compute: false,
         input_types: [
             ActionsListIOTypes.STRING,
             ActionsListIOTypes.NUMBER,

diff --git a/apps/core/src/domain/actions/validateRegexAction.ts b/apps/core/src/domain/actions/validateRegexAction.ts
@@ -13,6 +13,7 @@ export default function (): IActionsListFunction<{regex: true}> {
         input_types: [ActionsListIOTypes.STRING],
         output_types: [ActionsListIOTypes.STRING],
         params: [{name: 'regex', type: 'string', description: 'Validation regex', required: true, default_value: ''}],
+        compute: false,
         action: (values, params) => {
             const allErrors = values.reduce<Array<{errorType: Errors; attributeValue: IValue}>>(
                 (errors, elementValue) => {

diff --git a/apps/core/src/domain/actions/validateURLAction.ts b/apps/core/src/domain/actions/validateURLAction.ts
@@ -12,6 +12,7 @@ export default function (): IActionsListFunction {
         description: 'Check if value is a string matching URL format',
         input_types: [ActionsListIOTypes.STRING],
         output_types: [ActionsListIOTypes.STRING],
+        compute: false,
         action: (values: IValue[]) => {
             const allErrors = values.reduce<Array<{errorType: Errors; attributeValue: IValue}>>(
                 (errors, elementValue) => {

diff --git a/apps/core/src/domain/attribute/attributeDomain.ts b/apps/core/src/domain/attribute/attributeDomain.ts
@@ -26,6 +26,7 @@ import {IActionsListDomain} from '../actionsList/actionsListDomain';
 import getPermissionCachePatternKey from '../permission/helpers/getPermissionCachePatternKey';
 import {getActionsListToSave, getAllowedInputTypes, getAllowedOutputTypes} from './helpers/attributeALHelper';
 import {validateAttributeData} from './helpers/attributeValidationHelper';
+import {ActionsListEvents} from '../../_types/actionsList';
 
 export interface IAttributeDomain {
     getAttributeProperties({id, ctx}: {id: string; ctx: IQueryInfos}): Promise<IAttribute>;
@@ -55,6 +56,8 @@ export interface IAttributeDomain {
      * Retrieve libraries linked to attribute
      */
     getAttributeLibraries(params: {attributeId: string; ctx: IQueryInfos}): Promise<ILibrary[]>;
+
+    doesCompute(attrData: IAttribute): boolean;
 }
 
 export interface IAttributeDomainDeps {
@@ -112,6 +115,13 @@ export default function ({
     };
 
     return {
+        doesCompute(attrData): boolean {
+            const availableActions = actionsListDomain.getAvailableActions();
+
+            return attrData.actions_list[ActionsListEvents.GET_VALUE].some(
+                action => availableActions.find(availableAction => availableAction.id === action.id).compute
+            );
+        },
         async getLibraryAttributes(libraryId: string, ctx): Promise<IAttribute[]> {
             const _execute = async () => {
                 const libs = await libraryRepo.getLibraries({params: {filters: {id: libraryId}}, ctx});

diff --git a/libs/ui/src/__mocks__/common/attribute.ts b/libs/ui/src/__mocks__/common/attribute.ts
@@ -134,7 +134,15 @@ export const mockFormAttribute: RecordFormAttributeFragment = {
             }
         }
     ],
-    versions_conf: null
+    versions_conf: null,
+    compute: false
+};
+
+export const mockFormAttributeCompute: RecordFormAttributeFragment = {
+    ...mockFormAttribute,
+    id: 'test_compute_attribute',
+    format: AttributeFormat.text,
+    compute: true
 };
 
 export const mockFormAttributeTree: RecordFormAttributeTreeAttributeFragment = {

diff --git a/libs/ui/src/__mocks__/common/value.ts b/libs/ui/src/__mocks__/common/value.ts
@@ -43,6 +43,7 @@ export const mockRecordPropertyWithAttribute: IRecordPropertyWithAttribute = {
         },
         multiple_values: false,
         readonly: false,
-        permissions: {access_attribute: true, edit_value: true}
+        permissions: {access_attribute: true, edit_value: true},
+        compute: false
     }
 };