Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] Import data/config: add versions, trees #366

Merged
merged 7 commits into from
Jan 10, 2024
Merged

[Core] Import data/config: add versions, trees #366

merged 7 commits into from
Jan 10, 2024

Conversation

stevenfreville
Copy link
Collaborator

No description provided.

@stevenfreville stevenfreville requested review from jrmyb and TdyP December 7, 2023 13:10
@stevenfreville stevenfreville force-pushed the import-data-upgrade-from-op branch from 0279669 to 1a33615 Compare December 7, 2023 14:07
TdyP
TdyP requested changes Dec 7, 2023
View reviewed changes
apps/core/src/_types/import.ts Outdated Show resolved Hide resolved
apps/core/src/domain/attribute/attributeDomain.ts Outdated Show resolved Hide resolved
apps/core/src/domain/eventsManager/eventsManagerDomain.ts Outdated Show resolved Hide resolved
apps/core/src/domain/import/import-data-schema.json Show resolved Hide resolved
apps/core/src/domain/import/import-data-schema.json Outdated Show resolved Hide resolved
apps/core/src/domain/import/importDomain.ts Outdated Show resolved Hide resolved
apps/core/src/domain/import/importDomain.ts Outdated Show resolved Hide resolved
apps/core/src/domain/import/importDomain.ts Outdated Show resolved Hide resolved
apps/core/src/domain/value/helpers/validateValue.ts Outdated Show resolved Hide resolved
apps/core/src/utils/utils.ts Outdated Show resolved Hide resolved
@stevenfreville stevenfreville force-pushed the import-data-upgrade-from-op branch from d68028b to bd8cc4d Compare December 7, 2023 15:41
@stevenfreville stevenfreville requested a review from TdyP December 8, 2023 09:31
@stevenfreville stevenfreville force-pushed the import-data-upgrade-from-op branch from 2cb4e5b to 38e593f Compare December 8, 2023 11:06
jrmyb
jrmyb requested changes Dec 8, 2023
View reviewed changes
apps/core/src/domain/value/helpers/validateValue.ts Show resolved Hide resolved
apps/core/src/domain/import/importDomain.ts Outdated Show resolved Hide resolved
apps/core/src/domain/import/importDomain.ts Show resolved Hide resolved
apps/core/src/domain/import/importDomain.ts Outdated Show resolved Hide resolved
apps/core/src/domain/import/importDomain.ts Outdated Show resolved Hide resolved
apps/core/src/domain/import/importDomain.ts Outdated Show resolved Hide resolved
apps/core/src/domain/import/importDomain.ts Outdated Show resolved Hide resolved
apps/core/src/domain/import/importDomain.ts Outdated Show resolved Hide resolved
@stevenfreville stevenfreville requested review from TdyP and jrmyb December 11, 2023 08:07
@stevenfreville stevenfreville force-pushed the import-data-upgrade-from-op branch 2 times, most recently from 3f4c867 to c98a893 Compare December 12, 2023 09:12
@stevenfreville stevenfreville force-pushed the import-data-upgrade-from-op branch 2 times, most recently from 5c86415 to 141c1a5 Compare January 5, 2024 14:31
@stevenfreville stevenfreville force-pushed the import-data-upgrade-from-op branch from 141c1a5 to b253bd5 Compare January 10, 2024 11:00
@jrmyb jrmyb changed the title Upgrade importData function to support versionable values [Core] Import data / config : add versions, trees Jan 10, 2024
@jrmyb jrmyb changed the title [Core] Import data / config : add versions, trees [Core] Import data/config: add versions, trees Jan 10, 2024
@jrmyb jrmyb merged commit 7e967bc into master Jan 10, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrmyb jrmyb jrmyb approved these changes

@AdilAristid AdilAristid AdilAristid approved these changes

@TdyP TdyP Awaiting requested review from TdyP

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stevenfreville @jrmyb @TdyP @AdilAristid